Style changes in RecoTracker/DeDx

[tvami]

PR description:

I was going to do some development in RecoTracker/DeDx but noticed that many thing dont comply with the coding rules
https://cms-sw.github.io/cms_coding_rules.html

So this PR does several style changes in that package regarding the following rules:

• 2.7 For namespaces use lower case
• 2.8 Start method names with lowercase, use upper case initials for following words
• 2.9 Start data member names with lower case. A trailing “_” is the preferred method to distinguish a data member from the getter method
• 6.3 Only header files that expose a public interface should go into the Package/Subpackage/interface directory.

Besides this,

• some variable names were changed (more descriptive name),
• French comments were translated to English (if that's incorrect let me know...)
• Spelling mistakes were fixed (Reccord)
• Tried to reduce code duplication
• Removed commented out code

Changes are just cosmetics, so no changes in the tests are expected.

After this merges, I have a follow-up with some real changes included.

PR validation:

scram b runtests runs fine (except for the case when I have file opening errors)

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37231/28830

• This PR adds an extra 780KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CalibTracker/SiStripChannelGain (alca)
• FastSimulation/SimplifiedGeometryPropagator (fastsim)
• HLTrigger/Configuration (hlt)
• PhysicsTools/PatAlgos (reconstruction)
• RecoTracker/DeDx (reconstruction)

@malbouis, @ssekmen, @yuanchao, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @missirol, @clacaputo, @Martin-Grunewald, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @felicepantaleo, @hatakeyamak, @robervalwalsh, @emilbols, @Martin-Grunewald, @mbluj, @ahinzmann, @demuller, @mmusich, @seemasharmafnal, @mmarionncern, @jdolen, @silviodonato, @JanFSchulte, @missirol, @azotz, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @alesaggio, @ebrondol, @mtosi, @dgulhan, @AlexDeMoor, @gbenelli, @JyothsnaKomaragiri, @gpetruc, @matt-komm, @mariadalfonso, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6633/23084/summary.html
COMMIT: fbded5c
CMSSW: CMSSW_12_4_X_2022-03-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37231/23084/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695377
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695341
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

Indeed, please code a customisation function in HLTrigger/Configuration/python/customizeHLTforCMSSW.py to make the change if the old parameter Reccord occurs in the py config. See the file for examples - and make sure you add a call to the customisation function at the end of that file.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37231/28841

• This PR adds an extra 792KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Refactore PropagateToMuon and add propagation to L3 muon filters at HLT #37180

[cmsbuild]

Pull request #37231 was updated. @malbouis, @ssekmen, @yuanchao, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @missirol, @clacaputo, @Martin-Grunewald, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

[tvami]

I will squash the commits, but let's see first if @cms-sw/reconstruction-l2 has any comments or not

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37231/28865

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #37231 was updated. @malbouis, @ssekmen, @yuanchao, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @missirol, @clacaputo, @Martin-Grunewald, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6633/23149/summary.html
COMMIT: a080f29
CMSSW: CMSSW_12_4_X_2022-03-15-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37231/23149/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695377
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695335
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• see Style changes in RecoTracker/DeDx #37231 (comment)

[clacaputo]

+reconstruction

• style changes in RecoTracker/DeDx in compliance with cms coding rules
• no reco changes expected or observed

[Martin-Grunewald]

+1

[tvami]

Hi @sbein the fast-sim changes are trivial, can you please sign it?

[qliphy]

merge
As requested there is a follow-up PR waiting for this one. @sbein let's know if you have any concern.

[qliphy]

merge