Phase2-hgx305 Update the hgcalcell xml files in view of foressen corrections

[bsunanda]

PR description:

Update the hgcalcell xml files in view of foressen corrections. We foresee a new plugin code for creating the cells which will require two additional parameters. The new code will take care of the V17 cells but is not expected to modify cells for earlier version. However the parameters are needed for earlier version as well.

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37448/29141

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-399067/23628/summary.html
COMMIT: ade8d8e
CMSSW: CMSSW_12_4_X_2022-04-03-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37448/23628/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3592997
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[bsunanda]

@srimanob Please sign this. We are waiting for this PR to be merged to go to the next step

[srimanob]

Hi @bsunanda
Am I understand correctly that this update to XML files will effect all HGCAL version, but not now?
I seems it touches all versions used for C9-C17 in https://github.com/cms-sw/cmssw/blob/master/Configuration/Geometry/python/dict2026Geometry.py

[bsunanda]

Hope it does not. The modified algorithm needs 2 additional parameters which will affect V17 geometry of HGCal and hopefully not the earlier ones. But those parameters need to be defined for all versions of XML file

[bsunanda]

We need that version to be checked in next and without this PR it cannot be tested

[srimanob]

Thanks. I think this is an information that should be in the PR description. This will us to understand and in case needs to look back if there is an issue.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

@srimanob done an addiotnal comment

[perrotta]

+1