Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmsLHEtoEOSManager.py to use python used by cmsRun #37514

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 9, 2022

cmsLHEtoEOSManager.py is shared by all cmssw releases as it gets deployed under /cvmfs/cms.cern.ch/share/overrides/bin (which comes first in PATH after cmsenv). As reported in #37512, after python2 to python3 migration this script does not work any more in slc6 env ( due to missing python3). The change here proposed to use the python used by cmsRun . This is the same trick we did for few other shared python tools (https://github.com/cms-sw/cmssw-wm-tools/tree/master/bin).

Fixes #37512

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37514/29229

  • This PR adds an extra 12KB to repository

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • GeneratorInterface/LHEInterface (generators)

@alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Apr 9, 2022

please test

@smuzaffar
Copy link
Contributor Author

@SiewYan , tests were already running :-( now bot has to start over again :-)

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 9, 2022

Updated script now works under CMSSW_8_0_X release

lxplus> cmssw-slc6
Singularity> eval `scram run -sh /cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_31`
Singularity> which cmsRun
/cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_31/bin/slc6_amd64_gcc530/cmsRun
Singularity> wget -q https://raw.githubusercontent.com/cms-sw/cmssw/dce29d59b27f6d76631bf991fbcb0452181a3c79/GeneratorInterface/LHEInterface/scripts/cmsLHEtoEOSManager.py
Singularity> chmod +x cmsLHEtoEOSManager.py
Singularity> ./cmsLHEtoEOSManager.py -l 19738
Starting cmsLHEtoEOSManager.py

cmsLHEtoEOSmanager Revision: 1.13

Running on  Sat Apr  9 15:34:36 2022

Action: list content of article 19738

Upsilon1s_8TeV.lhe.xz

@SiewYan
Copy link
Contributor

SiewYan commented Apr 9, 2022

@SiewYan , tests were already running :-( now bot has to start over again :-)

Sorry @smuzaffar , i was not seeing it carefully ..

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-780b4a/23796/summary.html
COMMIT: dce29d5
CMSSW: CMSSW_12_4_X_2022-04-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37514/23796/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593015
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Apr 11, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a78608a into cms-sw:master Apr 11, 2022
@jordan-martins
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmsLHEtoEOSManager.py python3 vs python2 in 8_0_X builder
5 participants