-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmsLHEtoEOSManager.py to use python used by cmsRun #37514
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37514/29229
|
please test |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@SiewYan , tests were already running :-( now bot has to start over again :-) |
Updated script now works under CMSSW_8_0_X release
|
Sorry @smuzaffar , i was not seeing it carefully .. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-780b4a/23796/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Thanks! |
cmsLHEtoEOSManager.py
is shared by all cmssw releases as it gets deployed under/cvmfs/cms.cern.ch/share/overrides/bin
(which comes first in PATH after cmsenv). As reported in #37512, after python2 to python3 migration this script does not work any more in slc6 env ( due to missing python3). The change here proposed to use thepython
used bycmsRun
. This is the same trick we did for few other shared python tools (https://github.com/cms-sw/cmssw-wm-tools/tree/master/bin).Fixes #37512