EL9: Fix OpenSSL warnings

[smuzaffar]

These chanegs should fix the remaining OpenSSL warnings

PhysicsTools/SelectorUtils/interface/VersionedSelector.h:60:8: warning: 'unsigned char* MD5(const unsigned char*, size_t, unsigned char*)' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
    60 |     MD5((unsigned char*)tracked.c_str(), tracked.size(), id_md5_);

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37629/29404

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37629/29404/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37629/29404/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37629/29405

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• CondCore/CondDB (db)
• DQMServices/FileIO (dqm)
• GeneratorInterface/SherpaInterface (generators)
• PhysicsTools/SelectorUtils (reconstruction)
• Utilities/OpenSSL (core)

@SiewYan, @Saptaparna, @jpata, @alberto-sanchez, @makortel, @ahmad3213, @cmsbuild, @GurpreetSinghChahal, @pmandrik, @smuzaffar, @Dr15Jones, @emanueleusai, @jfernan2, @slava77, @ggovi, @micsucmed, @francescobrivio, @malbouis, @mkirsano, @clacaputo, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@barvic, @mkirsano, @wddgit, @thuer, @alberto-sanchez, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test for el9_amd64_gcc11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bd645/24043/summary.html
COMMIT: bd520f2
CMSSW: CMSSW_12_4_X_2022-04-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37629/24043/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3589913
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bd645/24047/summary.html
COMMIT: bd520f2
CMSSW: CMSSW_12_4_X_2022-04-19-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37629/24047/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 66030 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 422641
• DQMHistoTests: Total nulls: 280
• DQMHistoTests: Total successes: 3166994
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6520000000000001 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.874 ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
• Checked 200 log files, 45 edm output root files, 48 DQM output files

[mmusich]

---> test testCalibTrackerSiStripESProducersByHand had ERRORS
---> test testPixelDBs had ERRORS
---> test testCondToolsSiStripBuildersReaders had ERRORS

all of this is related to #37593 (comment)

[tvami]

@cmsbuild , please test with #37674

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bd645/24248/summary.html
COMMIT: bd520f2
CMSSW: CMSSW_12_4_X_2022-04-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37629/24248/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /pool/condor/dir_287101/jenkins/workspace/compare-root-files-short-matrix/data/PR-6bd645/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical, no changes
• the reco code changes are limited to VersionedSelector, which AFAIK is only used by EGamma in private Run2 calibration (see discussion in Restructure VID Python/FWLite code and avoid generating dictionaries for Reco*/*Identification packages #35953 on the VID)

[smuzaffar]

@cms-sw/generators-l2 @cms-sw/dqm-l2 can you please review this?

[emanueleusai]

+1

[smuzaffar]

@cms-sw/generators-l2 kind reminder to review this

[SiewYan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1