Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monopole autoskim #37655

Merged
merged 2 commits into from May 13, 2022
Merged

Update monopole autoskim #37655

merged 2 commits into from May 13, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Apr 22, 2022

PR description:

This main goal for this PR is to update autoSkim for monopole analysis. However, the structure of autoSkim has been updated following the discussion in #37656

  • autoSkimRunII is made (clone of current autoSkim).
  • autoSkim is now for Run-3. The review and following PR should come when PDs are available.

PR validation:

None. No change is expected for the PR test since monopole skim will not change anything in DQM histograms.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No need of backport.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37655/29457

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @wajidalikhan, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37655/29566

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37655 was updated. @cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@kskovpen
Copy link
Contributor

Thanks @srimanob

@kskovpen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4445/24307/summary.html
COMMIT: ae24d24
CMSSW: CMSSW_12_4_X_2022-04-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37655/24307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

Ping @cms-sw/pdmv-l2

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 13, 2022

please test
just to refresh

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4445/24703/summary.html
COMMIT: ae24d24
CMSSW: CMSSW_12_4_X_2022-05-13-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37655/24703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697377
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697347
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@tvami
Copy link
Contributor

tvami commented Jul 19, 2022

hi @srimanob (writing with my ORM hat this week),
I have a question and a comment:
EXOMONOPOLE is being added to SinglePhoton, but SinglePhoton doesnt exists since 2017/2018. I hope that's clear.
And then the question: EXOMONOPOLE is not added to MET, is that on purpose? Thanks

@srimanob
Copy link
Contributor Author

Hi @tvami

Here are clarifications:

  • For this PR, I made monopole on both singlephoton and egamma and I leave the message at the PR description that "autoSkim is now for Run-3. The review and following PR should come when PDs are available." So I expect responsible person to review and make an updated PR.
  • It is by intension not to do the skim on MET (yet). We need analysis strategy, and reduce more the size. I may request when rereco happens.

@tvami
Copy link
Contributor

tvami commented Jul 19, 2022

Thanks Phat, I'll then remove the monopole skim from the MET in the T0 config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants