[12_3_X] Do not fetch PixelClusterCountsInEvent when the handle is not valid

[tvami]

PR description:

See #37712

PR validation:

test parameters:

• workflows = 1001.2,1020

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37712

[tvami]

test parameters:

• workflows = 1001.2,1020

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_3_X.

It involves the following packages:

• Calibration/LumiAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from do not fetch PixelClusterCountsInEvent when the handle is not valid #37712

[tvami]

backport of #37712

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f21ad4/24289/summary.html
COMMIT: d2c4029
CMSSW: CMSSW_12_3_X_2022-04-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37720/24289/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f21ad4/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f21ad4/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3697317
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3697281
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 214 log files, 45 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[perrotta]

@tvami thank you for the fix!
I'd give your signature for granted, now that tests succeed also in 12_3. But I'll let you have the chance to look once again at it in the next hour or so, before force merging in time to have this included in the 1100 IB.

[mmusich]

But I'll let you have the chance to look once again

I think Tamas is currently on US Eastern time, so there are slim chances he'll be awake in the next hour or so.
Perhaps @francescobrivio could sign instead?

[perrotta]

But I'll let you have the chance to look once again

I think Tamas is currently on US Eastern time, so there are slim chances he'll be awake in the next hour or so. Perhaps @francescobrivio could sign instead?

Good point. Let force merge it now, then.
Tamas, you'll have time to complain (if you want so...) when you wake up, and in any case before when we start building the new release :-)

[perrotta]

+1

• Fix for [12_3_X] Update the AlCaRecoMatrix for Run 3 #37671

[perrotta]

merge

[tvami]

Haha no complains. Indeed, just woke up :)

[tvami]

+alca

• for the record

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will be automatically merged.