[L1T] switch to GeomeryDB #37726

cecilecaillol · 2022-04-28T13:18:47Z

PR description:

Addresses issue #31113 ("Configuration.StandardSequences.Geometry_cff was removed")

cmsbuild · 2022-04-28T13:25:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37726/29576

This PR adds an extra 64KB to repository

cmsbuild · 2022-04-28T13:25:32Z

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

EventFilter/L1GlobalTriggerRawToDigi (l1)
L1Trigger/CSCTrackFinder (l1)
L1Trigger/DTTrigger (l1)
L1Trigger/GlobalCaloTrigger (l1)
L1Trigger/GlobalTriggerAnalyzer (l1)
L1Trigger/HardwareValidation (l1)
L1Trigger/RPCTechnicalTrigger (l1)
L1Trigger/RegionalCaloTrigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2022-04-28T13:25:47Z

please test

cmsbuild · 2022-04-28T17:13:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a3c3c/24314/summary.html
COMMIT: 1c53ff5
CMSSW: CMSSW_12_4_X_2022-04-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37726/24314/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3695410
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-04-29T07:38:46Z

+l1

cmsbuild · 2022-04-29T07:39:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-04-29T07:52:19Z

+1

Test configs updated

mmusich · 2022-04-29T07:56:41Z

EventFilter/L1GlobalTriggerRawToDigi/test/L1GtPacker_cfg.py

@@ -276,7 +276,7 @@
 # load and configure modules via Global Tag
 # https://twiki.cern.ch/twiki/bin/view/CMS/SWGuideFrontierConditions

-process.load('Configuration.StandardSequences.Geometry_cff')
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')

 process.GlobalTag.globaltag = useGlobalTag+'::All'


just wanted to mention that all the ::All here are relics from Cond DB version 1 and they certainly cannot work with the current DB infrastructure.

just wanted to mention that all the ::All here are relics from Cond DB version 1 and they certainly cannot work with the current DB infrastructure.

Good point, thank you Marco. Then a further update/adjustment is in ordere, @cecilecaillol

mmusich · 2022-04-29T08:57:37Z

EventFilter/L1GlobalTriggerRawToDigi/test/L1GtRecord_cfg.py

@@ -114,7 +114,7 @@
 # load and configure modules via Global Tag
 # https://twiki.cern.ch/twiki/bin/view/CMS/SWGuideFrontierConditions

-process.load('Configuration.StandardSequences.Geometry_cff')
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')

 process.GlobalTag.globaltag = useGlobalTag+'::All'


mmusich · 2022-04-29T08:57:44Z

EventFilter/L1GlobalTriggerRawToDigi/test/L1GtTriggerMenuLite_cfg.py

@@ -33,7 +33,7 @@
 # load and configure modules via Global Tag
 # https://twiki.cern.ch/twiki/bin/view/CMS/SWGuideFrontierConditions

-process.load('Configuration.StandardSequences.Geometry_cff')
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')

 process.GlobalTag.globaltag = useGlobalTag+'::All'


mmusich · 2022-04-29T08:57:57Z

L1Trigger/CSCTrackFinder/test/csctfEfficiencySim_cfg.py

@@ -35,7 +35,7 @@
 ##############
 process.load("Configuration.StandardSequences.Services_cff")
 process.load("Configuration.StandardSequences.MagneticField_cff")
-process.load("Configuration.StandardSequences.Geometry_cff")
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load("Configuration.StandardSequences.Simulation_cff")
 process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
 process.GlobalTag.globaltag ='START52_V1::All'


mmusich · 2022-04-29T08:58:09Z

L1Trigger/GlobalTriggerAnalyzer/test/L1GtPackUnpackAnalyzer_cfg.py

@@ -109,7 +109,7 @@
 # load and configure modules via Global Tag
 # https://twiki.cern.ch/twiki/bin/view/CMS/SWGuideFrontierConditions

-process.load('Configuration.StandardSequences.Geometry_cff')
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')

 process.GlobalTag.globaltag = useGlobalTag+'::All'


mmusich · 2022-04-29T08:58:17Z

L1Trigger/GlobalTriggerAnalyzer/test/L1GtTechTrigL1GtEmulTrigReport_cfg.py

@@ -210,7 +210,7 @@
 # load and configure modules via Global Tag
 # https://twiki.cern.ch/twiki/bin/view/CMS/SWGuideFrontierConditions

-process.load('Configuration.StandardSequences.Geometry_cff')
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')

 process.GlobalTag.globaltag = useGlobalTag + '::All'


mmusich · 2022-04-29T08:58:24Z

L1Trigger/RegionalCaloTrigger/test/testRCTEmulator.py

@@ -16,7 +16,7 @@
 )

 # standard includes
-process.load("Configuration.StandardSequences.Geometry_cff")
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
 process.GlobalTag.globaltag = "IDEAL_30X::All"


mmusich · 2022-04-29T08:58:30Z

L1Trigger/RegionalCaloTrigger/test/testTPGManipulation_cfg.py

@@ -16,7 +16,7 @@
 )

 # standard includes
-process.load("Configuration.StandardSequences.Geometry_cff")
+process.load("Configuration.StandardSequences.GeometryDB_cff")
 process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
 process.GlobalTag.globaltag = "IDEAL_30X::All"


switch to GeomeryDB

1c53ff5

cmsbuild added this to the CMSSW_12_4_X milestone Apr 28, 2022

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Apr 28, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 28, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 28, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Apr 29, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 29, 2022

cmsbuild merged commit aa6b51c into cms-sw:master Apr 29, 2022

mmusich reviewed Apr 29, 2022

View reviewed changes

cecilecaillol mentioned this pull request Apr 29, 2022

[L1T] remove ::All from Cond DB version #37735

Merged

mmusich reviewed Apr 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[L1T] switch to GeomeryDB #37726

[L1T] switch to GeomeryDB #37726

cecilecaillol commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

cecilecaillol commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

cecilecaillol commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

perrotta commented Apr 29, 2022

mmusich Apr 29, 2022

perrotta Apr 29, 2022

mmusich Apr 29, 2022

mmusich Apr 29, 2022

mmusich Apr 29, 2022

mmusich Apr 29, 2022

mmusich Apr 29, 2022

mmusich Apr 29, 2022

mmusich Apr 29, 2022

[L1T] switch to GeomeryDB #37726

[L1T] switch to GeomeryDB #37726

Conversation

cecilecaillol commented Apr 28, 2022

PR description:

cmsbuild commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

cecilecaillol commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

Comparison Summary

cecilecaillol commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

perrotta commented Apr 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment