Fix SiPixel Layer 1 efficiency calculation

[tsusa]

PR description:

Following #35058 a few fixes/changes in L1 efficiency calculation/hit classification are introduced: reject TrajectoryMeasurements w/o pixel hit, fix min.distance calculation and filling of the inactive hits, initialize valid/missing/passcuts_hit for each loop iteration.

Changes expected in L1 efficiency and hit classification.

PR validation:

Matrix run, no issue.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37778/29678

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiPixelPhase1Track/plugins/SiPixelPhase1TrackEfficiency.cc modified in PR(s): Remove an unneeded assignment for passcuts_hit in SiPixelPhase1TrackEfficiency #35058

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37778/29678/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37778/29678/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37778/29681

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiPixelPhase1Track/plugins/SiPixelPhase1TrackEfficiency.cc modified in PR(s): Remove an unneeded assignment for passcuts_hit in SiPixelPhase1TrackEfficiency #35058

[cmsbuild]

A new Pull Request was created by @tsusa (Tatjana Susa) for master.

It involves the following packages:

• DQM/SiPixelPhase1Track (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tsusa]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01c91/24414/summary.html
COMMIT: 781b6c7
CMSSW: CMSSW_12_4_X_2022-05-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37778/24414/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 79
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700447
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

@tsusa can you change the title to reflect this targets SiPixel?

[emanueleusai]

+1

[perrotta]

please test
(log for failing 1002.0 got truncated: try once more to see if it is transient)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01c91/24490/summary.html
COMMIT: 0d4e2e3
CMSSW: CMSSW_12_4_X_2022-05-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37778/24490/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700704
• DQMHistoTests: Total failures: 90
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3700591
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

@tsusa could you please confirm that the differences reported in the PR tests after the last changes are still the ones expected?
e.g. in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_4_X_2022-05-05-2300+d01c91/50085/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA/PixelPhase1_Tracks_PXBarrel_Shell_pO_PXLayer_1.html

[tsusa]

@perrotta the changes in pixel plots are the same as before the last commit (see for example the changes in the plots that you pointed out https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_4_X_2022-05-03-1100+d01c91/50016/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA/PixelPhase1_Tracks_PXBarrel_Shell_pO_PXLayer_1.html)

There are two additional failed wf (10224.0 and 312.0) after the last commit (not present before) but the differences come from the MessageLogger.

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[mmusich]

type trk

[mmusich]

type bug-fix

[mmusich]

@tsusa @perrotta is a backport to 12.3.X in order here, as it's essentially a bug-fix?

[perrotta]

@tsusa @perrotta is a backport to 12.3.X in order here, as it's essentially a bug-fix?

@mmusich @tsusa this is DQM, and therefore I see no counterindication in backporting it in 12_3. If you think that it can be useful to monitor the first part of this year data taking, feel free to prepare a backport PR

[mmusich]

here it is: #37859