Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AlCaPhiSymEcal_Nano inherit from pp instead of AlCa #37784

Merged
merged 1 commit into from May 4, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented May 3, 2022

PR description:

Outcome of dmwm/T0#4664 is that the RECO steps were not run. This PR now changes the inheritance of the AlCaPhiSymEcal_Nano to inherit from pp instead of AlCa

PR validation:

python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario AlCaPhiSymEcal_Nano --reco --global-tag 123X_dataRun3_Prompt_v6 --lfn=file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2022/AlCaPhiSym/RAW/v91/000/346/512/00000/4887980a-dac3-48e0-be08-d99284f75c5b.root --alcareco EcalPhiSymByRun

gives a config which now has

process.schedule = cms.Schedule(*[ process.raw2digi_step, process.L1Reco_step, process.reconstruction_step0, process.reconstruction_step1, process.reconstruction_step2, process.pathALCARECOEcalPhiSymByRun, process.dqmoffline_step, process.write_RECO_step, process.write_DQMIO_step, process.write_ALCARECO_step, process.ALCARECOStreamEcalPhiSymOutNanoPath ], tasks=[process.patAlgosToolsTask])

where

process.reconstruction_step0 = cms.Path(process.bunchSpacingProducer)
process.reconstruction_step1 = cms.Path(process.ecalMultiFitUncalibRecHitTask)
process.reconstruction_step2 = cms.Path(process.ecalCalibratedRecHitTask)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport but backport to 12_3_X is needed.

@tvami
Copy link
Contributor Author

tvami commented May 3, 2022

assign alca

@tvami
Copy link
Contributor Author

tvami commented May 3, 2022

urgent

  • let's aim to have this for the upcoming pre-release

@tvami
Copy link
Contributor Author

tvami commented May 3, 2022

atn @simonepigazzini @davidlange6

@tvami
Copy link
Contributor Author

tvami commented May 3, 2022

type bugfix

@tvami
Copy link
Contributor Author

tvami commented May 3, 2022

type ecal

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37784/29692

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @cmsbuild, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented May 3, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9ec2/24423/summary.html
COMMIT: 52c49cf
CMSSW: CMSSW_12_4_X_2022-05-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37784/24423/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3700548
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3700512
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • changes in line with PR description
  • jenkin tests clean (except usual known MTD and MessageLogger stuff)

@perrotta
Copy link
Contributor

perrotta commented May 4, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants