-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AlCaPhiSymEcal_Nano
inherit from pp
instead of AlCa
#37784
Conversation
assign alca |
urgent
|
type bugfix |
type ecal |
3509cc8
to
c1b97f1
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37784/29692
|
c1b97f1
to
52c49cf
Compare
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@perrotta, @malbouis, @yuanchao, @tvami, @cmsbuild, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9ec2/24423/summary.html Comparison SummarySummary:
|
+alca
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Outcome of dmwm/T0#4664 is that the RECO steps were not run. This PR now changes the inheritance of the
AlCaPhiSymEcal_Nano
to inherit frompp
instead ofAlCa
PR validation:
gives a config which now has
where
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport but backport to 12_3_X is needed.