Module for putting an invariant mass cut on the (mu,mu,gamma) triplet #37797

ats2008 · 2022-05-04T10:16:57Z

PR description:

Towards the development of a new dedicated HLT Trigger for Bs->MuMuGamma.

Implementation modified from : HLTrigger/HLTfilters/plugins/HLTDoubletDZ.*

PR validation:

Setup

cmsrel CMSSW_12_4_0_pre3
cd CMSSW_12_4_0_pre3/src
cmsenv
git cms-init
git cms-merge-topic ats2008:devForBsToMuMUGammaTrig
scram b -j 8

Get A proxy HLT Path

hltGetConfiguration  /users/athachay/BmmgDev_12_4/V5 \
    --full \
    --offline \
    --no-output \
    --mc \
    --eras Run3 \
    --process MYHLT \
    --prescale 2.0e34+ZB+HLTPhysics \
    --input file:/afs/cern.ch/work/a/athachay/private/bs2mumug/hltDev/bmmg/CMSSW_12_3_0_pre6/menuDev/bs2mmg_GEN-SIM-DIGI-RAW_120X.root \
    --paths HLTriggerFirstPath,HLT_DoubleMu4_3_EG4_BsToMMG_v1,HLTriggerFinalPath \
    --max-events 100 \
    --setup /dev/CMSSW_12_4_0/GRun/V8 \
    --l1-emulator uGT \
    --l1Xml L1Menu_Collisions2022_v1_0_0.xml \
    > hltMC.py

Get the customization code :

cp /afs/cern.ch/work/a/athachay/public/BsToMuMuGamma/customizeForBMMG.py .

Add the customization lines to the end of hltMC.py. This will replace hltDisplacedDimuEG4DZFilter with a module of type HLTMuMuPhotonMass added in the PR

from cutsomizeForBMMG import customizeHLTforBsToMuMuGamma
process=cusomizeHLTforBsToMuMuGamma(process, 100 )

For testing please run the hltMC.py and check the displayed Trigger results of the path HLT_DoubleMu4_3_EG4_BsToMMG_v1

cmsRun hltMC.py

Trigger studies for the proposed trigger , in BPH Trigger Meeting.

cmsbuild · 2022-05-04T10:23:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37797/29708

This PR adds an extra 16KB to repository

cmsbuild · 2022-05-04T10:23:41Z

A new Pull Request was created by @ats2008 (Aravind Sugunan) for master.

It involves the following packages:

HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol

@ats2008 , a first set of comments from my side.

missirol · 2022-05-04T16:50:32Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+
+template <typename T1, typename T2, typename T3>
+HLTTripletMass<T1, T2, T3>::~HLTTripletMass() {}


Suggested change

template <typename T1, typename T2, typename T3>

HLTTripletMass<T1, T2, T3>::~HLTTripletMass() {}

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

missirol · 2022-05-04T16:52:50Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+
+  desc.add<bool>("is1and2Same", false);
+  desc.add<bool>("is2and3Same", false);
+  descriptions.add(defaultModuleLabel<HLTTripletMass<T1, T2, T3>>(), desc);


Suggested change

descriptions.add(defaultModuleLabel<HLTTripletMass<T1, T2, T3>>(), desc);

descriptions.addWithDefaultLabel(desc);

HLTrigger/HLTfilters/plugins/HLTTripletMass.h

missirol · 2022-05-04T16:55:21Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.h

+//
+// Class imlements |dZ|<Max for a pair of two objects
+//


Update comment.

missirol · 2022-05-06T09:57:02Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+        filterproduct.addCollectionTag(originTag2_[i]);
+      }
+      tagOld = edm::InputTag();
+      for (trigger::size_type i3 = 0; i3 != n2; ++i3) {


Suggested change

for (trigger::size_type i3 = 0; i3 != n2; ++i3) {

for (trigger::size_type i2 = 0; i2 != n2; ++i2) {

Just naming, but should be i2, no?

missirol · 2022-05-06T09:58:51Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.h

+  const int triggerType3_;
+  const std::vector<double> min_InvMass_;  // minimum invariant mass of pair
+  const std::vector<double> max_InvMass_;  // maximum invariant mass of pair
+  const double max_DR_;                    // maximum invariant mass of pair


Wrong comment.

missirol · 2022-05-06T09:59:33Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+        for (; i3 != coll3.size(); i3++) {
+          r3 = coll3[i3];
+          dauC_p4 = reco::Particle::LorentzVector(r3->px(), r3->py(), r3->pz(), r3->energy());
+          if (reco::deltaR2(dauAB_p4, dauC_p4) > max_DR_) {


Why cut on DeltaR^2 while the name of the parameter suggests this is DeltaR?

Ya ! that was a mistake , resolved ! thx

HLTrigger/HLTfilters/plugins/HLTTripletMass.h

cmsbuild · 2022-05-06T11:36:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37797/29759

This PR adds an extra 20KB to repository

cmsbuild · 2022-05-06T11:36:42Z

Pull request #37797 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

ats2008 · 2022-05-06T12:14:49Z

adopted many suggestions from @missirol in the last commit.

cmsbuild · 2022-05-06T12:20:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37797/29760

This PR adds an extra 20KB to repository

cmsbuild · 2022-05-06T12:20:30Z

Pull request #37797 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

ats2008 · 2022-05-09T09:16:01Z

Dear maintainers could you please review further and please try get this PR within the next pre-release ?

@cms-bot urgent

perrotta · 2022-05-09T09:21:34Z

@ats2008 please merge the .h and .cc files into one (HLTTripletMass.cc)
Among other things, that would allow you to easily remove duplicate header includes between the two files

missirol · 2022-05-09T09:25:09Z

@ats2008 , I will complete the review of the PR later today.

missirol

@ats2008 , here's a 2nd round of review.

missirol · 2022-05-09T10:12:23Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+typedef HLTTripletMass<reco::RecoChargedCandidate, reco::RecoChargedCandidate, reco::RecoEcalCandidate>
+    HLTMuMuPhotonMass;
+DEFINE_FWK_MODULE(HLTMuMuPhotonMass);


Once the h and cc files are merged, please move the instantiation to the file plugins/plugins.cc.

Please use the name HLT3MuonMuonPhotonMass, in analogy with existing plugins, e.g.

cmssw/HLTrigger/HLTfilters/plugins/HLTDoubletDZ.cc

Line 649 in 30df01c

typedef HLTDoubletDZ<reco::Electron, reco::Electron> HLT2ElectronElectronDZ;

missirol · 2022-05-09T10:13:51Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+  accept = accept and (n >= min_N_);
+  return accept;


Suggested change

accept = accept and (n >= min_N_);

return accept;

return (accept and n >= min_N_);

missirol · 2022-05-09T10:27:55Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+        for (; i3 != coll3.size(); i3++) {
+          r3 = coll3[i3];
+          dauC_p4 = reco::Particle::LorentzVector(r3->px(), r3->py(), r3->pz(), r3->energy());
+          if (reco::deltaR(dauAB_p4, dauC_p4) > max_DR_) {


Suggested change

if (reco::deltaR(dauAB_p4, dauC_p4) > max_DR_) {

if (reco::deltaR2(dauAB_p4, dauC_p4) > max_DR2_) {

Use DeltaR-2 for the cut (faster).

missirol · 2022-05-09T10:29:25Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+              accept = true;
+            }
+
+            if (accept)
+              break;


Suggested change

accept = true;

}

if (accept)

break;

accept = true;

break;

}

missirol · 2022-05-09T10:32:32Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+          }
+        }
+        if (accept)
+          break;


Why do break in L209 and L213? Doesn't one want to find and count all the tri-candidates that pass the selection?

yes , removing break makes sense since min_N_ is also a parameter to the filter . I will update it

cmsbuild · 2022-05-10T16:37:49Z

Pull request #37797 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

missirol

I think a couple of includes can be removed. @ats2008 , if you force-push again, please fix the commit message (right now, it's long and not very instructive).

missirol · 2022-05-10T16:34:03Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+#include "DataFormats/Common/interface/Handle.h"
+#include "DataFormats/Common/interface/Ref.h"
+#include "DataFormats/RecoCandidate/interface/RecoChargedCandidate.h"
+#include "DataFormats/RecoCandidate/interface/RecoChargedCandidateFwd.h"


Suggested change

#include "DataFormats/RecoCandidate/interface/RecoChargedCandidateFwd.h"

missirol · 2022-05-10T16:34:12Z

HLTrigger/HLTfilters/plugins/HLTTripletMass.cc

+#include "DataFormats/RecoCandidate/interface/RecoChargedCandidate.h"
+#include "DataFormats/RecoCandidate/interface/RecoChargedCandidateFwd.h"
+#include "DataFormats/RecoCandidate/interface/RecoEcalCandidate.h"
+#include "DataFormats/RecoCandidate/interface/RecoEcalCandidateFwd.h"


Suggested change

#include "DataFormats/RecoCandidate/interface/RecoEcalCandidateFwd.h"

ats2008 · 2022-05-10T17:05:35Z

Have updated the files according to the suggestions from @perrotta and @missirol

ats2008 · 2022-05-10T17:07:00Z

Okay , did not see last comment by @missirol , will update

@Perrota

…object mass criteria Accomodating multiple suggestions from @Perrota and @missirol removing extra headers and adding some more

cmsbuild · 2022-05-10T20:12:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37797/29903

This PR adds an extra 16KB to repository

cmsbuild · 2022-05-10T20:12:25Z

Pull request #37797 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

missirol · 2022-05-10T20:44:38Z

please test

cmsbuild · 2022-05-11T00:36:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c26ef/24596/summary.html
COMMIT: b7c5b29
CMSSW: CMSSW_12_4_X_2022-05-10-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37797/24596/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3696633
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3696609
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

missirol · 2022-05-11T05:56:44Z

+hlt

adds a new HLT filter, not presently used in any central wfs or HLT menus

cmsbuild · 2022-05-11T05:57:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-11T09:03:43Z

+1

cmsbuild added this to the CMSSW_12_4_X milestone May 4, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending labels May 4, 2022

ats2008 changed the title ~~Module for putting an invariant mass cut on the (mu,mu,gamma) tripplet~~ Module for putting an invariant mass cut on the (mu,mu,gamma) triplet May 4, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 4, 2022

ats2008 marked this pull request as ready for review May 5, 2022 06:01

missirol reviewed May 6, 2022

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels May 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 6, 2022

cmsbuild added code-checks-pending and removed code-checks-approved labels May 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 6, 2022

missirol reviewed May 9, 2022

View reviewed changes

missirol reviewed May 10, 2022

View reviewed changes

dev commit for adding a new module for filtering events based on tri-…

b7c5b29

…object mass criteria Accomodating multiple suggestions from @Perrota and @missirol removing extra headers and adding some more

ats2008 force-pushed the devForBsToMuMUGammaTrig branch from f5692b3 to b7c5b29 Compare May 10, 2022 20:05

cmsbuild added code-checks-pending and removed code-checks-approved labels May 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 10, 2022

cmsbuild added tests-started and removed tests-pending labels May 10, 2022

cmsbuild added tests-approved and removed tests-started labels May 11, 2022

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels May 11, 2022

cmsbuild added orp-approved and removed orp-pending labels May 11, 2022

cmsbuild merged commit d56c5df into cms-sw:master May 11, 2022

This was referenced May 11, 2022

DeepSC algorithm for ECAL SuperClusters #37115

Merged

Changes to enable new DeepTauId trainig #37892

Merged


		template <typename T1, typename T2, typename T3>
		HLTTripletMass<T1, T2, T3>::~HLTTripletMass() {}

	descriptions.add(defaultModuleLabel<HLTTripletMass<T1, T2, T3>>(), desc);
	descriptions.addWithDefaultLabel(desc);

	for (trigger::size_type i3 = 0; i3 != n2; ++i3) {
	for (trigger::size_type i2 = 0; i2 != n2; ++i2) {

	accept = accept and (n >= min_N_);
	return accept;
	return (accept and n >= min_N_);

	if (reco::deltaR(dauAB_p4, dauC_p4) > max_DR_) {
	if (reco::deltaR2(dauAB_p4, dauC_p4) > max_DR2_) {

Module for putting an invariant mass cut on the (mu,mu,gamma) triplet #37797

Module for putting an invariant mass cut on the (mu,mu,gamma) triplet #37797

Conversation

ats2008 commented May 4, 2022 • edited

PR description:

PR validation:

cmsbuild commented May 4, 2022

cmsbuild commented May 4, 2022

missirol left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented May 6, 2022

cmsbuild commented May 6, 2022

ats2008 commented May 6, 2022

cmsbuild commented May 6, 2022

cmsbuild commented May 6, 2022

ats2008 commented May 9, 2022

perrotta commented May 9, 2022

missirol commented May 9, 2022

missirol left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented May 10, 2022

missirol left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ats2008 commented May 10, 2022

ats2008 commented May 10, 2022

cmsbuild commented May 10, 2022

cmsbuild commented May 10, 2022

missirol commented May 10, 2022

cmsbuild commented May 11, 2022

Comparison Summary

missirol commented May 11, 2022

cmsbuild commented May 11, 2022

perrotta commented May 11, 2022

ats2008 commented May 4, 2022 •

edited