Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Bugfixes for DQM/BeamMonitor #37802

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #37801 to 12_3_X.
This PR fixes two bugs introduced in #37614:

  • Remove the logToDb_ flag from onlineDbService_->lockRecords() and onlineDbService_->releaseLocks() as this flag is only meant to affect the logging, not the locking of records
  • Add a flag (loggerActive_) to avoid calling onlineDbService_->logger().end() in case onlineDbService_->logger().start() was never called

PR validation:

Backport:

Backport of #37801

FYI @gennai @dzuolo @ggovi

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

  • DQM/BeamMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

type bug-fix

@francescobrivio
Copy link
Contributor Author

backport of #37801

@francescobrivio
Copy link
Contributor Author

test parameters:

  • addpkg = DQM/Integration

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dd922/24448/summary.html
COMMIT: 26a86d9
CMSSW: CMSSW_12_3_X_2022-05-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37802/24448/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696087
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696057
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

tested at P5

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

Pull request #37802 was updated. @ggovi, @malbouis, @tvami, @francescobrivio can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 6, 2022

+1

  • Master PR successfully merged since CMSSW_12_4_X_2022-05-05-2300

@cmsbuild cmsbuild merged commit 9d5cda4 into cms-sw:CMSSW_12_3_X May 6, 2022
@francescobrivio francescobrivio deleted the alca-fixDQMclients_12_3_X branch May 6, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants