Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQMFileSaver capabilities for FU #3786

Merged
merged 13 commits into from May 15, 2014
Merged

DQMFileSaver capabilities for FU #3786

merged 13 commits into from May 15, 2014

Conversation

diguida
Copy link
Contributor

@diguida diguida commented May 9, 2014

Adding methods to DQMFileSaver to deal with histogram creation at Filter Unit in DAQ2.
Later fixes (following comments in my branch) to come very soon.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_1_X.

DQMFileSaver capabilities for FU

It involves the following packages:

DQMServices/Components
DQMServices/Core

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

Pull request #3786 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/1425/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/1425/summary.html

@deguio
Copy link
Contributor

deguio commented May 14, 2014

@diguida I didn't get if I have to wait for an additional commit or not.
@nclopezo the bot didn't realise that this PR has been updated.. another commit may come though.
cheers,
F.

Salvatore Di Guida added 2 commits May 14, 2014 16:14
Remove code duplication for FilterUnit convention: added static funct…
9775e0a 
…ion for generating file names for ROOT and PB format, modified saveForFilterUnit and saveForFilterUnitPB for saving the contents of DQMStore for ROOT and PB format.
Added the DQMFileSaver configuration parameter for setting the file f…
ffcf234 
…ormat.
@cmsbuild
Copy link
Contributor

Pull request #3786 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/1514/summary.html

@deguio
Copy link
Contributor

deguio commented May 14, 2014

hello @nclopezo
could you run again the tests for this PR? a couple of commits have just arrived.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented May 14, 2014

+1
as soon as tests confirm that everything runs normal (the changes shouldn't affect the functionality).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/1520/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request May 15, 2014
@nclopezo
Merge pull request #3786 from diguida/rebase_fastMergerPB
78d7ae8 
DQM -- DQMFileSaver capabilities for FU
@nclopezo nclopezo merged commit 78d7ae8 into cms-sw:CMSSW_7_1_X May 15, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3786/1520/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@diguida @cmsbuild @deguio @rovere @nclopezo