-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more context to exception message in externalGenerator #37871
Conversation
Add what the program was doing when the exception happened.
NOTE: in the IBs we are getting infrequent failures of the externalGenerator where BOOST is throwing an exception with a not-so-informative message (i.e. just a generic |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37871/29835
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ed0e8/24545/summary.html Comparison SummarySummary:
|
Unit test does show new information[*]. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Code compiles and unit tests show the new information.