-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Gathering detail plots into directories, online & offline & relval & …" #38052
Revert "Gathering detail plots into directories, online & offline & relval & …" #38052
Conversation
A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_3_X. It involves the following packages:
@civanch, @emanueleusai, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736a8d/24929/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Hi @perrotta, It's not a good idea to revert the PR because it has a lot of other updates which is necessary for the GEM DQM. I'll make a hotfix as soon as possible. |
At the daily joint operation meeting was decided righ now to merge this revert PR in 12_3, and build a patch release with it that can be safely tested in time for the first stable beams of the year expected for Friday morning. Following the usual procedure, the fix will get merged in the master first. tested for working, and backported in 12_4. Once it has been demonstrated to have no issues, a backport PR in 12_3_X can be merged in the online DQM release at any time. Therefore, we can still have GEM monitoring in DQM online for the first stable beams, provided the fix is prepared quickly, and in the meanwhile T0 operations and tests can continue without being blocked by it. Of course, all discussions about the PRs to be merged in the releases can be made at the Tuesday's ORP meetings, next one being in a few hours from now, see https://indico.cern.ch/event/1160356/ |
@cms-sw/dqm-l2 @cms-sw/simulation-l2 could you please sign this PR, in order to document that you agree with it? |
+1 |
+1
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged. |
Reverts #37852, to have it ready just in case it needs to get merged
See #38044 for the discussion about the issues with #37852,