Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Gathering detail plots into directories, online & offline & relval & …" #38052

Merged
merged 1 commit into from May 24, 2022

Conversation

perrotta
Copy link
Contributor

Reverts #37852, to have it ready just in case it needs to get merged
See #38044 for the discussion about the issues with #37852,

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_3_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • Validation/Configuration (dqm, simulation)

@civanch, @emanueleusai, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@apsallid, @ebrondol, @rovere, @watson-ij, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736a8d/24929/summary.html
COMMIT: d84a148
CMSSW: CMSSW_12_3_X_2022-05-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38052/24929/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736a8d/24929/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-736a8d/24929/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3624636
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3624598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -65153.668 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -147.714 KiB GEM/Digis
  • DQMHistoSizes: changed ( 10024.0,... ): 18.914 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 11634.0,... ): -2170.807 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): -11.172 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 11634.0,... ): -0.770 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 23234.0,... ): -4332.684 KiB GEM/Digis
  • DQMHistoSizes: changed ( 23234.0,... ): 5.781 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 35034.0,... ): -6048.131 KiB GEM/Digis
  • DQMHistoSizes: changed ( 35034.0,... ): 13.969 KiB GEM/RecHits
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@quark2
Copy link
Contributor

quark2 commented May 24, 2022

Hi @perrotta,

It's not a good idea to revert the PR because it has a lot of other updates which is necessary for the GEM DQM. I'll make a hotfix as soon as possible.

@perrotta
Copy link
Contributor Author

perrotta commented May 24, 2022

At the daily joint operation meeting was decided righ now to merge this revert PR in 12_3, and build a patch release with it that can be safely tested in time for the first stable beams of the year expected for Friday morning.

Following the usual procedure, the fix will get merged in the master first. tested for working, and backported in 12_4. Once it has been demonstrated to have no issues, a backport PR in 12_3_X can be merged in the online DQM release at any time. Therefore, we can still have GEM monitoring in DQM online for the first stable beams, provided the fix is prepared quickly, and in the meanwhile T0 operations and tests can continue without being blocked by it.

Of course, all discussions about the PRs to be merged in the releases can be made at the Tuesday's ORP meetings, next one being in a few hours from now, see https://indico.cern.ch/event/1160356/

@perrotta
Copy link
Contributor Author

@cms-sw/dqm-l2 @cms-sw/simulation-l2 could you please sign this PR, in order to document that you agree with it?

@ahmad3213
Copy link
Contributor

+1

@perrotta
Copy link
Contributor Author

+1

  • Merging this, in order to build the patch release as soon as possible

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit dfb6115 into CMSSW_12_3_X May 24, 2022
@perrotta perrotta deleted the revert-37852-GEM-onlineDQMRearrange-12_3_X branch May 24, 2022 09:31
@civanch
Copy link
Contributor

civanch commented May 24, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants