-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oot pileup boostio #3806
Oot pileup boostio #3806
Conversation
A new Pull Request was created by @igv4321 for CMSSW_7_1_X. Oot pileup boostio It involves the following packages: CondCore/HcalPlugins @apfeiffer1, @diguida, @cmsbuild, @anton-a, @thspeer, @rcastello, @slava77, @ggovi, @Degano, @nclopezo can you please review it and eventually sign? Thanks. |
Hi Igor, Please post some details to document the changes (best to be in the PR description field, up at the top):
Thank you |
Hi Slava, There may be very minor changes to default physics outputs. Perhaps, the best reference which describes the algorithm is Regards, On 05/12/2014 09:15 AM, Slava Krutelyov wrote:
|
+1 |
@@ -0,0 +1,80 @@ | |||
#ifndef RecoLocalCalo_HcalRecAlgos_BoostIODBReader_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reader and the writer should be removed from HcalRecAlgos. Please, move to /test if really necessary to be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Slava,
I don't think this should be in "test". This code can be used
with arbitrary objects serializable by boost and with arbitrary
record classes. I am sure it will be useful in the future to
instantiate these templates with other template parameters.
Since the code is header-only, it does not affect linking
dependencies of RecoLocalCalo/HcalRecAlgos sources.
And, of course, at this point this code has direct relationship
to Hcal algorithms because it is used to store and retrieve OOT
pileup correction objects.
Regards,
Igor
On 05/13/2014 05:33 PM, Slava Krutelyov wrote:
In RecoLocalCalo/HcalRecAlgos/interface/BoostIODBReader.h:
@@ -0,0 +1,80 @@
+#ifndef RecoLocalCalo_HcalRecAlgos_BoostIODBReader_hThe reader and the writer should be removed from HcalRecAlgos. Please, move to /test if really necessary to be here.
—
Reply to this email directly or view it on GitHub https://github.com/cms-sw/cmssw/pull/3806/files#r12612585.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not going to be run in regular production application, only by experts once in a blue moon.
This is pretty much the definition of what should be in the test.
This comment refers to the instances defined in the plugin as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Slava,
While this code will not be run in regular production application,
it will be used to prepare production databases.
In principle, I agree that there is probably a better place for the
DB read/write headers. However, it is surely not "test". Why don't
we keep it as it is for pre8 (since everything works, and the deadline
is fast approaching), and I will find a better place for it before pre9.
Regards,
Igor
On 05/13/2014 09:37 PM, Slava Krutelyov wrote:
In RecoLocalCalo/HcalRecAlgos/interface/BoostIODBReader.h:
@@ -0,0 +1,80 @@
+#ifndef RecoLocalCalo_HcalRecAlgos_BoostIODBReader_hIt's not going to be run in regular production application, only by experts once in a blue moon.
This is pretty much the definition of what should be in the test.
This comment refers to the instances defined in the plugin as well.—
Reply to this email directly or view it on GitHub https://github.com/cms-sw/cmssw/pull/3806/files#r12618804.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems these should be moved to a Cond_/_/bin/ directory - has nothing to do with reconstruction indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and due to their current location we have an "Algos" package with a plugins directory in addition to the corresponding producers package. Always good. Anyway, please fix this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
What about CondTools/Hcal?
What are these about?
|
I have not seen these warnings in CMSSW_7_1_X_2014-05-10-1400 Thanks, On 05/13/2014 05:36 PM, Slava Krutelyov wrote:
|
Hi Igor,
As you do not use the macro (COND_SERIALIZABLE;) in your header files, but explicitly add the declaration “manually" (and the implementation in the sra/...cc files), the script cannot find anything to be serialised and prints the warning (which can be ignored as you handle things explicitly). cheers, andreas PS: The instructions on how to prepare new conditions classes in the “official” cmssw way are at: On 14 May 2014, at 01:11, igv4321 notifications@github.com wrote:
|
Can we have a way to silence the warnings in case things are done in a |
On Wed, May 14, 2014 at 9:12 AM, Giulio Eulisse notifications@github.comwrote:
that would only work with a brute-force hack (a la "if packagename == ...")
this would be the best case - though then the manual serialisation code cheers, andreas |
Hi Andreas, Please note that these warnings are printed about classes And, of course, the original purpose of proceeding via Regards, On 05/14/2014 02:38 AM, Andreas Pfeiffer wrote:
|
Hi Igor,
OK, so these classes are not meant to be stored as conditions ? And, of course, the original purpose of proceeding via
yes, and you do not want the dependencies of the script in the "outside
well, I certainly hope that you do not change the order of the members. ;) The script will take the order as they are in the header file, so that way The present planning is that the script will in the future do checks and Thanks, |
Hi Andreas, The classes about which the warnings were generated are just Yes, the dependencies of the script itself are rather heavy. Of course, I do not intend to change the order of the members. Regards, On 05/14/2014 03:50 AM, Andreas Pfeiffer wrote:
|
Hi Andreas, In principle, if the warnings are indeed generated by the script when Regards, On 05/14/2014 02:38 AM, Andreas Pfeiffer wrote:
|
Hi Giulio and Andreas, I was able to reproduce the warnings that Slava saw by simply setenv SCRAM_ARCH slc6_amd64_gcc490 This release, of course, does not yet have any code related to Since these warnings are a separate issue, I suggest merging Regards, On 05/14/2014 04:23 AM, Igor Volobouev wrote:
|
Hi all,
The warning is not, as I thought before, coming from a class not having the Giulio, if you want, I can "demote" these warnings to info, OTOH, they Thanks, |
@apfeiffer1 IMHO:
|
Ciao Giulio, @apfeiffer1 https://github.com/apfeiffer1 IMHO:
It's the last one. Will do. Thanks, |
.. and from now on the official language of CMS will be.. Italian.. mmm |
HCAL out-of-time pileup subtraction code, using boost io for storing objects