Migrate Tau HLT DQM to DQMGenericClient+DQMEDHarvester #3820
Conversation
Needed for unscheduled/threaded HLT, where the producers are no longer in the paths.
In favor of a common tool. DQMGenericClient does everything HLTTauPostProcessor does except the EfficiencyRefPrevious plot. HLTTauPostProcessor will be modified to produce only that in following commits.
Everything else is now done with DQMGenericClient. Remove HLTTauDQMSummaryPlotter as obsolete.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X. Migrate Tau HLT DQM to DQMGenericClient+DQMEDHarvester It involves the following packages: DQMOffline/Trigger @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
|
+1 thanks for taking care of the code migration. don't forget to update the google spreadsheet linked at: |
…nericClient DQM -- Migrate Tau HLT DQM to DQMGenericClient+DQMEDHarvester
|
@deguio Yes, I have checked that all the histograms should be there with the same contents as before (it took actually more effort than the changes themselves...). I've now updated the google spreadsheet. |
|
@makortel thanks. |
Use DQMGenericClient to produce all but one of the efficiency TProfiles, and simplify HLTTauPostProcessor to produce only the remaining TProfile that can't be done with DQMGenericClient (i.e. "EfficiencyRefPrevious" plot, where eff(bin) = N(bin)/N(bin-1), inside the "HLT_*" folders).
Infer the location of first L3 tau filter in the paths by looking the filter inputs instead of the location of the L3 tau producer. This will be needed when HLT goes to unscheduled/multithreaded, when producers are no longer in paths (and it works with current menus).
In addition some cleanup and small fixes to axis labels of some plots.
The histogram contents should stay the same, as should the set of histograms except DQMGenericClient adds new "globalEfficiencies" histogram in each subfolder it produces efficiency plots to.
FYI: @mbluj