-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_2_X] Push_back 0th weight manually, prevent duplication of PS weights in P8.30x #38248
Conversation
A new Pull Request was created by @SiewYan (Siewyan Hoh 何守仁) for CMSSW_12_2_X. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 555, 556 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44e330/25280/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
Hello @Saptaparna , it is hard to tell if the backport is working, given the targeted workflows are not run due to the missing matrix map. @perrotta , in this case, what do you propose to proceed? Thanks. |
@SiewYan Similarly as done in master, you may do some local checks? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Local test:
The results is expected , reduced to 46 wieghts x 10 events = 460 entry: |
+1 |
@agrohsje Sure. Would you please give a bit more details about the production campaign? |
The idea would be to use Run3Winter22wmLHEGS and friends. |
PR description:
Echoing PR's description from #38012, created by @SanghyunKo.
"
The weight storage logic in Pythia8 had been changed since 8.30x version, causing the duplication of PS weights in CMS. This PR prevents weight duplication by setting Pythia8ToHepMC::set_store_weights(false) and keeps the old weight structure the same as in UL by push_back 0th weight manually. Fixes #36705
"
The PR is needed for sample production for Early analysis, which rely on PS. @agrohsje
The Issue and PR involves:
PR validation:
Testing with the workflow 555, 556 (should reduce the number of weights from 134 to 46)
if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of PR #38012