Thread safe updates pixel DQM - updated digi no longer accesses null pointers

[leggat]

Thread safe and thread_unsafe updates, DigiSource updated all in one commit for pixel DQM.

[cmsbuild]

A new Pull Request was created by @leggat for CMSSW_7_1_X.

Thread safe updates pixel DQM - updated digi no longer accesses null pointers

It involves the following packages:

DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[deguio]

hello @leggat
thanks for this. the history of the commits is lost and I cannot disentangle what you did exactly. is this PR build on top of what I have done? what was the problem exactly?

thanks,
F.

[leggat]

hi @deguio
Ah, sorry. Yes, it is built on the 3781 PR . The only differences are in SiPixelMonitorDigi/src/SiPixelDigiSource.cc - on lines 746 and 244 an additional requirement of twoDimOnlyLayDisk being true is required before accessing the monitor elements that were causing the seg faults. They are only booked if this is true, but the SiPixelDigiModule code apparently didn't realise it hadn't booked them and was trying to access random memory.
Cheers,
Duncan

[deguio]

is this changing any of the histograms content or should we expect an exact match with pre7?
thanks. waiting for the tests to be completed. hopefully I will be able to approve before pre8 closes.

ciao,
F.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3836/1491/summary.html

[deguio]

+1
@leggat since you had to reorganise the code a little bit (thanks for this) please keep in touch with the validators to make sure that everything is behaving the right way.
thanks,
F.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3836/1491/summary.html

[wmtan]

To leggat and other DQM people: This commit to DQM/SiPixelMonitorDigi causes massive relval failures due to segfaults in the ROOT 6 IB. The segfaults do not occur in the same tests every time.
Since ROOT6 is not a high priority for you at this time, I don't expect you to do anything about this at the moment, but, If you do intend to fix this, let me know ASAP. Otherwise, I will attempt to back the
DQM/SiPixelMonitorDigi changes out of the ROOT6 IB for now, and this can be dealt with later.

[wmtan]

To leggat and other DQM people: After a short discussion with Chris Jones, I've decided to try and fix the problem seen in the ROOT6 IB rather than backing out the DQM/SiPixelMonitorDigi portion of this pull request.

[deguio]

most likely this commit will be removed. it is causing other crashes in standard relvals and I don't have time to have a look now. we will have time to debug next week. reporting here for the record:

Hi Federico, Dan

We are seeing some problems in the IBs - could you urgently have a look at these two crashes?

Thx
david

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-16-0200/pyRelValMatrixLogs/run/134.0_MinimumBiasBS+RunMinBias2011B+RECOD+ALCAPROMPT+ALCAHARVD/step2_MinimumBiasBS+RunMinBias2011B+RECOD+ALCAPROMPT+ALCAHARVD.log

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-16-0200/pyRelValMatrixLogs/run/4.29_RunMinBias2011B+RunMinBias2011B+HLTD+RECODreHLT+HARVESTDreHLT+SKIMDreHLT/step3_RunMinBias2011B+RunMinBias2011B+HLTD+RECODreHLT+HARVESTDreHLT+SKIMDreHLT.log

[wmtan]

FWIW, in the ROOT6 IB I could not reproduce any of the many segfaults seen in the ROOT6 IB when I ran the relvas myself on cmsdev04. All tests pass. The crashes are not reproducible, at least in the ROOT6 IB.

[ktf]

As you might have seen above, I reverted the merge of this pull request.

[leggat]

In case you haven't seen it, I fixed the raw data error in #3952 which should supersede this.