Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PCL Alignment Threshold object and record for HG PCL Alignment [12.4.X] #38371

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 14, 2022

backport of #38195, #38286 , #38273 and #38367

PR description:

This is a combined backport of PRs #38195, #38286 , #38273 and #38367 in order to lay down the necessary infrastructural changes to be able to run the Hight Granularity PCL workflow at Tier-0 for the 2022 pp collisions.
See the respective PRs for more details.

PR validation:

cmssw compiles, relies on the validation done for the master PRs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a verbatim backport of #38195, #38286 , #38273 and #38367

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)
  • CondCore/PCLConfigPlugins (db)
  • CondCore/Utilities (db)
  • CondFormats/DataRecord (db, alca)
  • CondFormats/PCLConfig (db, alca)
  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@adewit, @tocheng, @Martin-Grunewald, @missirol, @tlampen, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 14, 2022

urgent

  • as I am not sure that introducing new CondFormats will be accepted once 12_4_0 will be cut. To the attention of @cms-sw/alca-l2 .

@mmusich
Copy link
Contributor Author

mmusich commented Jun 14, 2022

please test

@tvami
Copy link
Contributor

tvami commented Jun 14, 2022

The conclusion at ORP was that it's fine to add a new CondFormat later on, so this PR should aim for 12_4_1 (i.e not urgent for 12_4_0)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd1512/25516/summary.html
COMMIT: 8f866f7
CMSSW: CMSSW_12_4_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38371/25516/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8562 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680335
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 14, 2022

+1

  • master PRs tested in IBs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jun 14, 2022

@perrotta @qliphy given that this just finished, maybe we could squeeze it for 12_4_0 ?

@perrotta
Copy link
Contributor

@mmusich could you please check the file CondFormats/PCLConfig/test/AlignPCLThresholdsWriter_cfg.py?
If I am not wrong, it is the only one which is not a verbatim backport of the PRs #38195, #38286 , #38273 and #38367 that you are mentioning in the description. Simply to confirm that it is really what you wanted, and nothing got escaped.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 14, 2022

Hi @perrotta

could you please check the file CondFormats/PCLConfig/test/AlignPCLThresholdsWriter_cfg.py?

I cherry-picked the commits, so I would be surprised if the file was really different. From a quick look, seems what I am expecting.

@perrotta
Copy link
Contributor

+1

  • For CMSSW_12_4_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants