-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PCL Alignment Threshold object and record for HG PCL Alignment [12.4.X] #38371
New PCL Alignment Threshold object and record for HG PCL Alignment [12.4.X] #38371
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
urgent
|
please test |
The conclusion at ORP was that it's fine to add a new CondFormat later on, so this PR should aim for 12_4_1 (i.e not urgent for 12_4_0) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd1512/25516/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@mmusich could you please check the file CondFormats/PCLConfig/test/AlignPCLThresholdsWriter_cfg.py? |
Hi @perrotta
I cherry-picked the commits, so I would be surprised if the file was really different. From a quick look, seems what I am expecting. |
+1
|
backport of #38195, #38286 , #38273 and #38367
PR description:
This is a combined backport of PRs #38195, #38286 , #38273 and #38367 in order to lay down the necessary infrastructural changes to be able to run the Hight Granularity PCL workflow at Tier-0 for the 2022 pp collisions.
See the respective PRs for more details.
PR validation:
cmssw
compiles, relies on the validation done for the master PRs.if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a verbatim backport of #38195, #38286 , #38273 and #38367