Clean up Phase-2 geometry (Up to D85)

[srimanob]

PR description:

This PR is to clean up Phase-2 Geometry as discussed in
#38594

There will be a follow up PR on resetting workflow number.

PR validation:

Comparison of outputs from runTheMatrix.py --what upgrade -n shows that we have less Phase-2 workflows. All D49-D85 workflows are removed. Log files can be found in /afs/cern.ch/user/s/srimanob/public/ForPhase2SW/Geometry/2022CleanUp

If this PR is a backport please specify the original PR and why you need to backport that PR.

No need of backport, or special requests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38702/30997

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Reorganize FastSim Run3 workflow #38660, Add run3 tracking low pu era #33532
  • File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Reorganize FastSim Run3 workflow #38660

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)
• Geometry/CMSCommonData (geometry, upgrade)

@perrotta, @rappoccio, @Dr15Jones, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @civanch, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@beaucero, @fabiocos, @vargasa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @bsunanda, @ebrondol, @kpedro88, @lecriste, @trtomei, @mmusich, @mtosi, @dgulhan, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a749/26162/summary.html
COMMIT: 1d6fa95
CMSSW: CMSSW_12_5_X_2022-07-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38702/26162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b4a749/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3339858
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3339816
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 46 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 196 log files, 45 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[srimanob]

hold

[cmsbuild]

Pull request has been put on hold by @srimanob
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[perrotta]

@cms-sw/pdmv-l2 any objection to merge this?

[kskovpen]

+pdmv

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[iarspider]

@srimanob IB Unit Tests still some of the removed geometries (GeometryExtended2026D49, GeometryExtended2026D76) and thus are failing, see e.g. this.

[srimanob]

Hi @iarspider
Thanks. I collect the unit test failure in #38594 (comment). I will follow up and provide fixes.

[srimanob]

Staring from CMSSW_12_6_X_2022-10-05-1100, unit tests seem to be OK now.