Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mini aod part3 (7.1.X) #3875

Merged
merged 25 commits into from
Jun 3, 2014
Merged

Mini aod part3 (7.1.X) #3875

merged 25 commits into from
Jun 3, 2014

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented May 14, 2014

Based on top of CMSSW_7_1_X_2014-05-08-0200 (but mergeable, at least as of now)

Include the relinking of e/gamma objects, more event content updates, functional cmsDriver integration.

Tested workflows:
cmsDriver.py miniAOD_data-prod -s PAT -n 100 --data --filein /store/relval/CMSSW_7_1_0_pre6/JetHT/RECO/PRE_R_71_V2_RelVal_jet2012C-v1/00000/2CBD40F5-E2C7-E311-8206-003048678AC0.root --eventcontent MINIAOD --runUnscheduled --conditions GR_R_70_V1::All --no_exec
cmsDriver.py miniAOD-prod -s PAT -n 100 --mc --filein /store/relval/CMSSW_7_1_0_pre6/RelValTTbar_13/GEN-SIM-RECO/PRE_LS171_V5-v1/00000/064AD022-51C7-E311-9714-003048679228.root --eventcontent MINIAODSIM --runUnscheduled --conditions auto:startup --no_exec
cmsDriver.py miniAOD-fsim-prod -s PAT -n 100 --mc --fast --filein /store/relval/CMSSW_7_1_0_pre7/RelValTTbar_13_AVE20/GEN-SIM-DIGI-RECO/PU_PRE_LS171_V7_FastSim-v1/00000/02658C92-B3D1-E311-98DB-02163E00CAA0.root --eventcontent MINIAODSIM --runUnscheduled --conditions PRE_LS171_V7::All --no_exec

@arizzi @bendavid

arizzi and others added 22 commits May 8, 2014 21:58
@arizzi @gpetruc
change ranges in packed cands, fix trackvertex unpacker, commented co…
c3db88a 
…de for covariance propagation to PCA
@arizzi @gpetruc
add hcal noise summary to the event content
0faac76
@gpetruc
Cleanup of shower shapes in pat::Electron:
199d394 
  * remove r9, sigmaIphiIphi from pat::Electron (in new releases it
    is already in reco::GsfElectron)
  * follow naming convention of PR cms-sw#3710 for the non-ZS ones
@bendavid @gpetruc
Adapt ConversionTools to mini aod (work with embedded tracks and add …
98e1be5 
…loose matching for reduced conversion collection)
@bendavid @gpetruc
add setters to egamma objects to allow relinking to reduced collectio…
2603033 
…ns for mini aod
@bendavid @gpetruc
add ReducedEGProducer for creating reduced collections of electrons a…
74c6185 
…nd photons with consistently relinked clusters and conversions
@bendavid @gpetruc
adapt mini aod configs to use reducedEgamma collections
35b4a01
@bendavid @gpetruc
add function to clear detid vector for supercluster slimming in miniaod
868a063
@bendavid @gpetruc
restore slimming of internal electron and photon variables
9e0b9f1
@bendavid @gpetruc
add additional flexibility in relinking and restore previous mini aod…
f44f759 
… behaviour of keeping supercluster and seed cluster for all output electrons and photons
@bendavid @gpetruc
remove include for deprecated header
d883cc0
@bendavid @gpetruc
adapt to conversion changes in 71x
0b1b1d3
@gpetruc
MiniAOD in cmsDriver for real (calling miniAOD_tools)
c213007 
Depends on cms-sw#3545 (queued) and cms-sw#3543 (already merged)
Tested:
1) cmsDriver.py miniAOD_data-prod -s PAT -n 100 --data --filein /store/relval/CMSSW_7_1_0_pre6/JetHT/RECO/PRE_R_71_V2_RelVal_jet2012C-v1/00000/2CBD40F5-E2C7-E311-8206-003048678AC0.root --eventcontent MINIAOD --runUnscheduled --conditions GR_R_70_V1::All --no_exec
2) cmsDriver.py miniAOD-prod -s PAT -n 100 --mc --filein /store/relval/CMSSW_7_1_0_pre6/RelValTTbar_13/GEN-SIM-RECO/PRE_LS171_V5-v1/00000/064AD022-51C7-E311-9714-003048679228.root --eventcontent MINIAODSIM --runUnscheduled --conditions auto:startup --no_exec
@gpetruc
Include reducedEgamma_cfi in slimming_cff
f30bee2
@gpetruc
PAT Tau relinking of references, and added universal accessors using …
67681bf 
…CandPtr
@arizzi @gpetruc
keep all LHE product independently of the module name
c115b68
@gpetruc
Make sure we run on AK4 jets (default seems to be still AK5).
9eada2b 
Use AK5PFCHS corrections while waiting for a new GT
@gpetruc
parton match also to status 23 for pythia 8
c1e4fa1
@gpetruc
Keep also status 22,23 and all top quarks
f00269c
@gpetruc
FwdRef and FwdPtr: Nullness and Availability are two different things
338d56e
@gpetruc
miniAOD in cmsDriver: fix for fastsim samples:
73258c7 
(--fast will replace some fastsim-incompatible MET filters with
 dummy boolean filters)
Tested successfully with: cmsDriver RelValTTbar_13-POSTLS170_V3_FastSim-v2 -s PAT -n 10000 --mc --fast --dasquery "file dataset=/RelValTTbar_13/CMSSW_7_0_0-POSTLS170_V3_FastSim-v2/GEN-SIM-DIGI-RECO" --eventcontent MINIAODSIM --runUnscheduled --conditions POSTLS170_V3::All --no_exec
@gpetruc
Keep also l1GtTriggerMenuLite (per-run product)
e3d073e
@gpetruc gpetruc mentioned this pull request May 21, 2014
Merged
@ktf
Copy link
Contributor

ktf commented May 21, 2014

+1
@davidlange6 I'll bypass your signature for operations. Complain if not ok. I'll in any case first merge this in 72X and then we see what to do here.

@davidlange6
Copy link
Contributor

Good - I was waiting for the core sw signature… but yes, 72x..

On May 21, 2014, at 8:43 PM, Giulio Eulisse notifications@github.com
wrote:

+1
@davidlange6 I'll bypass your signature for operations. Complain if not ok. I'll in any case first merge this in 72X and then we see what to do here.

—
Reply to this email directly or view it on GitHub.

@ktf ktf mentioned this pull request May 21, 2014
Merged
@arizzi
Copy link
Contributor

arizzi commented May 23, 2014

so now that is merged in 72X... what's the plan?

@slava77
Copy link
Contributor

slava77 commented May 23, 2014

I'm guessing you need a PR in 70X as a backport
(so far, I assumed that that one wasn't submitted because you waited for part 2 to be merged)

@slava77
Copy link
Contributor

slava77 commented May 23, 2014

also, if there are no problems in 72X so far (~24 hrs since first IB with the part3 included),
we could merge it here as well, in 71X
Giulio?

@arizzi
Copy link
Contributor

arizzi commented May 23, 2014

well in order to rebase the part3 on 70X (we have the branch ready since 3 weeks), we would need part2 to be integrated in 70X!! ( see #3667 )

This was referenced May 26, 2014
Merged
Merged
@gpetruc
Copy link
Contributor Author

gpetruc commented Jun 2, 2014

ping? (this very same git branch has been merged in 7.2.X almost two weeks ago).

davidlange6 added a commit that referenced this pull request Jun 3, 2014
@davidlange6
Merge pull request #3875 from gpetruc/miniAOD-part3-from-CMSSW_7_1_X_…
b932a3a 
…2014-05-08-0200

Mini aod part3 (7.1.X)
@davidlange6 davidlange6 merged commit b932a3a into cms-sw:CMSSW_7_1_X Jun 3, 2014
@gpetruc gpetruc deleted the miniAOD-part3-from-CMSSW_7_1_X_2014-05-08-0200 branch September 30, 2015 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available core-approved operations-pending orp-pending pending-signatures reconstruction-approved tests-rejected
Projects
None yet
Milestone
CMSSW_7_1_0_pre9
Development

Successfully merging this pull request may close these issues.
10 participants
@gpetruc @cmsbuild @arizzi @slava77 @rappoccio @vadler @ktf @davidlange6 @nclopezo @bendavid