Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Update the autoSkim.py for the Run3 skims and removed unused PD #38795

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

sam7k9621
Copy link
Contributor

PR description:

Addressed the comments in #38479

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

12_4_X backport of #38792

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2022

A new Pull Request was created by @sam7k9621 for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 20, 2022

backport of #38792

@tvami
Copy link
Contributor

tvami commented Jul 20, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45b976/26339/summary.html
COMMIT: 15343c0
CMSSW: CMSSW_12_4_X_2022-07-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38795/26339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676174
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

urgent

  • should go into the next 12_4_X

@tvami
Copy link
Contributor

tvami commented Jul 25, 2022

@cms-sw/orp-l2 the master of this PR has been in IBs for a while now, can we merge this?

@perrotta
Copy link
Contributor

@cms-sw/orp-l2 the master of this PR has been in IBs for a while now, can we merge this?

As soon as @cms-sw/pdmv-l2 signs it, yes
By the way, this PR backports both #38479 and #38792

@tvami
Copy link
Contributor

tvami commented Jul 25, 2022

I pingged Kirill

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 00b4816 into cms-sw:CMSSW_12_4_X Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants