Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] fix GeometryProducer and G4e examples #38906

Merged
merged 6 commits into from Jul 31, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 30, 2022

resolves #38739

PR description:

Should work for all Eras and geometry models.
The propagator "old" test needs a "refresh": it was based on the early use of Geane for Muon reconstruction that has been obsoleted years ago. It cannot even work at the moment as current propagator is limited to 2m

PR validation:

Relies on the unit tests implemented in this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

backport of #38864

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Jul 30, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

type tracking, bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • SimG4Core/GeometryProducer (simulation)
  • TrackPropagation/Geant4e (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @JanFSchulte, @rovere, @VinInn, @bsunanda, @lecriste, @ebrondol, @mtosi, @mmusich, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #38906 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6eedad/26547/summary.html
COMMIT: cb639a8
CMSSW: CMSSW_12_4_X_2022-07-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38906/26547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 30, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 31, 2022

+1

@cmsbuild cmsbuild merged commit e313621 into cms-sw:CMSSW_12_4_X Jul 31, 2022
@mmusich mmusich deleted the FixGeomProd branch July 31, 2022 07:43
@qliphy qliphy mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants