[124X backport] Add DY option to Embedding HepMC filter

[IzaakWN]

PR description

Backport of PR #38829

PR validation

See PR #38829 and https://indico.cern.ch/event/1170879/#2-validation-of-exclusive-dy-t

PR backporting

Backporting to CMSSW_12_4_X, for producing the Run-3 DYJetsToTauTauToMuTauh_M-50 sample for TauPOG studies, and allow the H → WW analysis to use this updated filter.

[cmsbuild]

A new Pull Request was created by @IzaakWN (Izaak) for CMSSW_12_4_X.

It involves the following packages:

• GeneratorInterface/Core (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add DY option to Embedding HepMC filter #38829

[SiewYan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5c043/26601/summary.html
COMMIT: 6b9c1d6
CMSSW: CMSSW_12_4_X_2022-08-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38938/26601/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676198
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3676162
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[Saptaparna]

Hi, do we expect some of the tests to fail?

[perrotta]

code-checks

[perrotta]

Hi, do we expect some of the tests to fail?

The code checks failed when this PR was submitted to the wrong branch. It is not a showstopper here.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38938/31590

• This PR adds an extra 8KB to repository

[cmsbuild]

Pull request #38938 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

[cmsbuild]

Pull request #38938 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

[cmsbuild]

Pull request #38938 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

[perrotta]

test parameters:

• workflow = 136.9
• addpkg = TauAnalysis/MCEmbeddingTools

[perrotta]

backport of #38829

[perrotta]

please test

[perrotta]

(It also backports #39090, which must be succesfully tested and merged in the master before this one)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5c043/26886/summary.html
COMMIT: 55e3eac
CMSSW: CMSSW_12_4_X_2022-08-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38938/26886/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a5c043/136.9_RunDoubleMuon2016C+RunDoubleMuon2016C+RAWRECOTE16+RAWRECOLHECLEANTE16+EMBEDHADTE16

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3677200
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[Saptaparna]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Both Add DY option to Embedding HepMC filter #38829 and [Fix] Make IncludeDY optional #39090 are now succesfully tested in master IBs