[12_4_X] Add run3 PPS TDC and SAMPIC relvals

[ChrisMisan]

PR description:

PR adds relvals for the TDC and SAMPIC Run3 calibrations.

PR validation:

wfs 1041,1043,1044

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #38893

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_4_X.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)
• CondFormats/PPSObjects (alca)
• Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@slomeo, @makortel, @fabferro, @tocheng, @fabiocos, @Martin-Grunewald, @missirol, @kpedro88, @grzanka, @trtomei, @mmusich, @beaucero, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

type ctpps

[ChrisMisan]

urgent

- this backport is needed for datataking

[ChrisMisan]

please test

[tvami]

hi @ChrisMisan please decouple the RelVal changes from the CalibPPS/TimingCalibration/plugins/PPSDiamondSampicTimingCalibrationPCLHarvester.cc and make this not urgent I'll make a PR that deals with the PPSDiamondSampicTimingCalibrationPCLHarvester.cc changes and a bit more that's needed for this to work at the T0 (with what's in here, it's not going to work)

[tvami]

@cmsbuild , please abort

[cmsbuild]

Pull request #38978 was updated. @malbouis, @yuanchao, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

[ChrisMisan]

PR was updated according to the suggestion #38978 (comment)

[ChrisMisan]

test parameters:

• workflows=1041, 1043, 1044

[ChrisMisan]

please test

[tvami]

Sorry @ChrisMisan I think we also need to decouple CondFormats/PPSObjects/src/PPSTimingCalibration.cc

[tvami]

@cmsbuild , please abort

[tvami]

@cmsbuild , please test with #38982

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78cb09/26674/summary.html
COMMIT: 24b6c02
CMSSW: CMSSW_12_4_X_2022-08-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38978/26674/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-78cb09/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-78cb09/1043.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSCALSAMPIC+ALCAHARVDPPSCALSAMPIC
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-78cb09/1044.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSCALRUN3+ALCAHARVDPPSCALRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677218
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

@cmsbuild please test

Just to refresh the test after almost a week.

[srimanob]

@ChrisMisan @tvami
Is this PR ready to go from your side? Just to refresh the test, then I will sign.

[tvami]

@ChrisMisan @tvami Is this PR ready to go from your side? Just to refresh the test, then I will sign.

Yes, it's all good! Thanks for signing!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78cb09/26782/summary.html
COMMIT: 24b6c02
CMSSW: CMSSW_12_4_X_2022-08-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38978/26782/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-78cb09/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-78cb09/1043.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSCALSAMPIC+ALCAHARVDPPSCALSAMPIC
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-78cb09/1044.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSCALRUN3+ALCAHARVDPPSCALRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677200
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

New added workflows run fine.

[bbilin]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1