ECAL - Implement follow up issues for Phase 2 GPU reconstruction #39195

thomreis · 2022-08-25T16:14:51Z

PR description:

This PR addresses the first two items in #38619. The edm::ExternalWork is removed from modules that do not need it and the kernel is modified to be able t run with any number of threads and blocks.
The PR also adds new matrix workflows for Phase 2 ECAL developments with GPUs (*.612). The existing *.61 workflows remain CPU only.

No changes to the output are expected.

PR validation:

No changes observed.
Tested also with WF 28234.61 by manually adding the gpu modifier to the reconstruction step of the WF.
Passes 32234.61 and the new 32234.612.

…modules.

cmsbuild · 2022-08-25T16:22:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39195/31806

This PR adds an extra 20KB to repository

cmsbuild · 2022-08-25T16:22:57Z

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

RecoLocalCalo/EcalRecProducers (reconstruction)

@jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@youyingli, @rchatter, @argiro, @apsallid, @thomreis, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

srimanob · 2022-08-25T17:18:58Z

enable gpu

srimanob · 2022-08-25T17:20:06Z

@cmsbuild please test

cmsbuild · 2022-08-25T21:15:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5812f4/27096/summary.html
COMMIT: 0c587d4
CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39195/27096/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19868
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: found differences in 1 / 3 workflows

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3693084
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3693048
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

jpata · 2022-08-26T08:44:16Z

assign heterogeneous

(kindly asking the experts to take a look)

cmsbuild · 2022-08-26T08:44:33Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

thomreis · 2022-08-26T08:46:51Z

I do not know where the difference in the GPU TriggerResults for 11634.512 HLT could come from. This PR only touches Phase 2 code, whereas 11634.512 is a Run 3 WF.

cmsbuild · 2022-08-27T13:35:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5812f4/27139/summary.html
COMMIT: 19b3b10
CMSSW: CMSSW_12_5_X_2022-08-26-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39195/27139/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5812f4/32234.612_TTbar_14TeV+2026D70_ecalDevelGPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5812f4/32234.61_TTbar_14TeV+2026D70_ecalDevel+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19866
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3695708
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3695669
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

jpata · 2022-08-29T08:09:23Z

+reconstruction

technical cleanup

AdrianoDee · 2022-08-31T06:09:07Z

+upgrade

thomreis · 2022-09-06T12:14:24Z

@cms-sw/pdmv-l2 do you have any comments on this?

kskovpen · 2022-09-06T12:23:20Z

+pdmv

cmsbuild · 2022-09-06T12:23:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-09-07T12:51:32Z

please test
(tests are 11 days old nowadays)

cmsbuild · 2022-09-07T19:11:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5812f4/27405/summary.html
COMMIT: 19b3b10
CMSSW: CMSSW_12_6_X_2022-09-07-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39195/27405/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5812f4/32234.612_TTbar_14TeV+2026D70_ecalDevelGPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5812f4/32234.61_TTbar_14TeV+2026D70_ecalDevel+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19868
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3618326
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618299
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

perrotta · 2022-09-09T06:58:36Z

+1

thomreis added 2 commits August 25, 2022 17:12

Remove unnecessary ExternalWork from ECAL Phase 2 GPU reconstruction …

298e789

…modules.

Allow kernel to run with any number of threads and blocks.

0c587d4

cmsbuild added this to the CMSSW_12_5_X milestone Aug 25, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 25, 2022

thomreis mentioned this pull request Aug 25, 2022

Follow up PR for PR #37695 ECAL Phase 2 weights method amplitude reconstruction on GPU #38619

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2022

cmsbuild added the heterogeneous-pending label Aug 26, 2022

Add ECAL Phase 2 reco development workflow with GPU offloading (*.612).

19b3b10

cmsbuild added code-checks-pending pdmv-pending tests-pending and removed tests-approved code-checks-approved labels Aug 26, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 27, 2022

smuzaffar modified the milestones: CMSSW_12_5_X, CMSSW_12_6_X Aug 28, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 29, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Aug 31, 2022

cmsbuild mentioned this pull request Sep 1, 2022

Adding V0 Validation Wfs to the RelVal Matrix #39215

Merged

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Sep 6, 2022

cmsbuild added tests-started and removed tests-approved labels Sep 7, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 7, 2022

cmsbuild added orp-approved and removed orp-pending labels Sep 9, 2022

cmsbuild merged commit 5a67ff9 into cms-sw:master Sep 9, 2022

cmsbuild mentioned this pull request Sep 9, 2022

[BuildRules] Updated unit test startup command cms-sw/cmsdist#8075

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ECAL - Implement follow up issues for Phase 2 GPU reconstruction #39195

ECAL - Implement follow up issues for Phase 2 GPU reconstruction #39195

thomreis commented Aug 25, 2022 •

edited

Loading

cmsbuild commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

srimanob commented Aug 25, 2022

srimanob commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

jpata commented Aug 26, 2022

cmsbuild commented Aug 26, 2022

thomreis commented Aug 26, 2022

cmsbuild commented Aug 27, 2022

jpata commented Aug 29, 2022

AdrianoDee commented Aug 31, 2022

thomreis commented Sep 6, 2022

kskovpen commented Sep 6, 2022

cmsbuild commented Sep 6, 2022

perrotta commented Sep 7, 2022

cmsbuild commented Sep 7, 2022

perrotta commented Sep 9, 2022

ECAL - Implement follow up issues for Phase 2 GPU reconstruction #39195

ECAL - Implement follow up issues for Phase 2 GPU reconstruction #39195

Conversation

thomreis commented Aug 25, 2022 • edited Loading

PR description:

PR validation:

cmsbuild commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

srimanob commented Aug 25, 2022

srimanob commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

GPU Comparison Summary

Comparison Summary

jpata commented Aug 26, 2022

cmsbuild commented Aug 26, 2022

thomreis commented Aug 26, 2022

cmsbuild commented Aug 27, 2022

GPU Comparison Summary

Comparison Summary

jpata commented Aug 29, 2022

AdrianoDee commented Aug 31, 2022

thomreis commented Sep 6, 2022

kskovpen commented Sep 6, 2022

cmsbuild commented Sep 6, 2022

perrotta commented Sep 7, 2022

cmsbuild commented Sep 7, 2022

GPU Comparison Summary

Comparison Summary

perrotta commented Sep 9, 2022

thomreis commented Aug 25, 2022 •

edited

Loading