Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shashlyk geom bug fix 1 #3943

Merged
merged 1 commit into from
May 21, 2014

Conversation

fratnikov
Copy link

Fix bugs in Shashlik RECO geometry and in EKDetId dense index

Adopt 1..210 shashlyk module numeration for the dense index
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fratnikov (Fedor Ratnikov) for CMSSW_6_2_X_SLHC.

Shashlyk geom bug fix 1

It involves the following packages:

DataFormats/EcalDetId
Geometry/CaloTopology

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented May 21, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

merge

cmsbuild added a commit that referenced this pull request May 21, 2014
@cmsbuild cmsbuild merged commit b8a885b into cms-sw:CMSSW_6_2_X_SLHC May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants