-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx325I Remove reference to 6 inch HGCal silicon wafers in 3 codes in Validation/HGCalValidation/plugins #39517
Conversation
…ion/HGCalValidation/plugins
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39517/32276
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
@cmsbuild Please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@perrotta @rappoccio @emanueleusai Jobs are failing randomly on different workflows and none is related to this PR |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a0d0a/27893/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
Differences in HGCAL DQM plots caused by formerly empty plots now being filled. @bsunanda can you confirm the changed plots look as expected? |
@emanueleusai Yes these are expected |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@perrotta @rappoccio please merge this PR |
+1 |
PR description:
Remove reference to 6 inch HGCal silicon wafers in 3 codes in Validation/HGCalValidation/plugins
PR validation:
Use the runTheMatrix test scenarios
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special