-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded trigger bits from Lumi ALCARECOs #39519
Conversation
@Moanwar, CMSSW_12_6_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
adding @tvami , @francescobrivio |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39519/32278
|
A new Pull Request was created by @Moanwar for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
HLTPaths = cms.vstring("AlCa_LumiPixelsCounts_Random_v*"), | ||
eventSetupPathsKey='', | ||
#HLTPaths = cms.vstring("AlCa_LumiPixelsCounts_Random_v*"), | ||
eventSetupPathsKey='AlCa_LumiPixelsCounts_Random_v*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this is the name of the key, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventSetupPathsKey='AlCa_LumiPixelsCounts_Random_v*', | |
eventSetupPathsKey='AlCaPCCRandom', |
I think this is what we need and then a new trigger bit in the GT
HLTPaths = cms.vstring("AlCa_LumiPixelsCounts_ZeroBias_v*"), | ||
eventSetupPathsKey='', | ||
#HLTPaths = cms.vstring("AlCa_LumiPixelsCounts_ZeroBias_v*"), | ||
eventSetupPathsKey='AlCa_LumiPixelsCounts_ZeroBias_v*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventSetupPathsKey='AlCa_LumiPixelsCounts_ZeroBias_v*', | |
eventSetupPathsKey='AlCaPCCZeroBias', |
@Moanwar kind reminder |
@Moanwar ping |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39519/32443
|
Pull request #39519 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again. |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b5478/28044/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: @slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39519/32524
|
Pull request #39519 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b5478/28180/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@perrotta , @rappoccio , I would like to report something weird that seems to be happening with this PR. |
@malbouis thank you for telling |
PR description:
Remove hardcoded trigger bits from AlCaRecos and include it as a key in the alcareco trigger bits tag in "ALCARECOAlCaPCCZeroBias" and "ALCARECOAlCaPCCRandom"
Two GTs were created to be included in this PR, with the correct AlCaRecoTriggerBits tag.
1- 124X_dataRun3_Express_frozen_v6 :
GlobalTag for Run3 data relvals (express GT) - identical to 124X_dataRun3_Express_v6 but with snapshot at 2022-10-04 14:22:26 (UTC)
Here is the link of difference of GT, old vs new : https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_Express_frozen_v4/124X_dataRun3_Express_frozen_v6
2- 124X_dataRun3_Prompt_frozen_v5 :
GlobalTag for Run3 data relvals (prompt GT) - identical to 124X_dataRun3_Prompt_v5 but with snapshot at 2022-10-04 14:19:51 (UTC)
Here is the link of difference of GT, old vs new : https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_Prompt_frozen_v4/124X_dataRun3_Prompt_frozen_v5
PR validation:
Not a backport, but will be backported for data-taking operations
@cms-AlCaDB/alca-tsg