Fix trigger matching issues in L1Trigger DQMOffline #39691
Conversation
|
Please take a look @epalencia , @cecilecaillol , and @vukasinmilosevic . |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39691/32517
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
@abrinke1 Thanks! Could you run "scram build code-checks" and "scram build code-format"? Could you please also replace all the couts with edmLogError/Warning/... ? |
|
Hi @cecilecaillol , thanks for the instructions: all code-checks should be implemented. All of the new "cout" statements are connected with the "m_verbose" flag, which is only used for developer testing and debugging, and is set here: These "cout" statements are not really warnings at all, and this follows the existing code approach: |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39691/32552
|
|
A new Pull Request was created by @abrinke1 for master. It involves the following packages:
@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-234fc6/28213/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
@abrinke1 I understand these couts are related to the verbose mode and are not errors or warnings, but couts are not allowed in CMSSW code anymore. You could use edmLogInfo (all possibilities detailed in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMessageLogger) |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-234fc6/28252/summary.html Comparison SummarySummary:
|
|
+l1 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Fixed issue in L1T Offline DQM preventing HLT objects from being found, which leads to empty Muon and EGamma efficiency plots. Tested in l1t-integration here:
cms-l1t-offline#1051
PR validation:
cmsDriver.py step2 --conditions 124X_dataRun3_Prompt_v4 --data --datatier RECO,DQMIO --era Run3 --eventcontent RECO,DQM --filein file:/eos/cms/store/data/Run2022C/Muon/RAW/v1/000/356/570/00000/a76e1b83-d169-4db6-8009-96d7b76ee22c.root --fileout file:step2.root --nStreams 2 --nThreads 8 --no_exec --number 10 --process RECO --python_filename step_2L1T_cfg.py --scenario pp --step RAW2DIGI,L1Reco,RECO,DQM:@L1TMuon
cmsDriver.py step3 --conditions 124X_dataRun3_Prompt_v4 --data --era Run3 --filein file:step2_inDQM.root --fileout file:step3.root --filetype DQM --nStreams 2 --no_exec --number 10 --python_filename step_3_cfg.py --scenario pp --step HARVESTING:DQMHarvestL1TMuon
Also can run the above replacing "L1TMuon" with "L1TEgamma", and with the following input file:
/eos/cms/store/data/Run2022C/EGamma/RAW/v1/000/356/570/00000/aa8267bc-e993-4ed2-920e-6349cc460523.root