Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove direct calls of DQMStore, move SusyPostProcessor to DQMHarvester #3984

Conversation

webermat
Copy link
Contributor

leftover calls of DQMStore and beginJob and endJob have been removed from all modules (endRun where not needed as well), the SusyPostProcessor has been move to DQMEDHarvester class.

The code was checked by running the matrix, since we call a value map for the ak4jetid of calojets, which has been added to the RECO sequence only recently. Development started from 7_1_X_2014-5-19-0200

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @webermat for CMSSW_7_1_X.

remove direct calls of DQMStore, move SusyPostProcessor to DQMHarvester

It involves the following packages:

DQMOffline/JetMET

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@webermat
Copy link
Contributor Author

webermat commented Jun 3, 2014

comparison is OK

@deguio
Copy link
Contributor

deguio commented Jun 3, 2014

@webermat
sorry for being late. I will review and approve later today.
thanks for this,
F.

@deguio
Copy link
Contributor

deguio commented Jun 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 4, 2014
…014-05-19-0200

remove direct calls of DQMStore, move SusyPostProcessor to DQMHarvester
@davidlange6 davidlange6 merged commit cd348eb into cms-sw:CMSSW_7_1_X Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants