Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give OnlineLuminosityRecord info to HLT's LumiMonitor plugin [12_5_X] #39896

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Oct 28, 2022

backport of #39859

PR description:

From the description of #39859:

This PR address the 2nd item in the description of #39756, plus a related comment in #39756 (comment).

The LumiMonitor DQM plugin, used inside HLT, is updated to read the values of online instantaneous luminosity and mean PU from the so-called 'online-metadata' digis, when the corresponding info from SCAL is not available (i.e. from Run 3 onwards).

To improve clarity, some of the plot labels, transient variables, and configuration parameters are renamed. I changed "scal lumi/PU" to a more generic "online lumi/PU", but of course feel free to suggest better names.

Minor technical improvements (e.g. const-ness of class data members) were done in the process.

(In case this is backported to 12_4_X, it should not warrant a new ConfDB parsing, since the new configuration parameter of LumiMonitor, i.e. onlineMetaDataDigis, already defaults to the intended collection; at the same time, hltOnlineMetaDataDigis should in principle be included in the DQMHistograms EndPath in the HLT menus.)

3a1fd65 fixes a couple of pixel-related harvesting outputs which depend on the outputs of the LumiMonitor plugin; please see #39859 (comment) for details.

This is not an exact backport because of 3af98ee: the renaming of the parameter LumiMonitor.FolderName (-> .folderName), done in #39859, is not backported to 12_5_X in order to avoid extra complications to HLT online operations.

PR validation:

None beyond the validation done for #39859.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39859

Fix for HLT online DQM.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)
  • DQMOffline/Trigger (dqm)
  • HLTrigger/Timer (hlt)

@Martin-Grunewald, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @silviodonato, @mtosi, @Fedespring, @Martin-Grunewald, @HuguesBrun, @jhgoh, @threus, @fwyzard, @rociovilar, @trocino, @cericeci, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b454d/28593/summary.html
COMMIT: 2590949
CMSSW: CMSSW_12_5_X_2022-10-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39896/28593/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3702776
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3702748
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 221.00700000000003 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.039 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 11634.0,... ): 27.582 KiB PixelPhase1/Tracks
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #39896 was updated. @Martin-Grunewald, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

I figured it's better not to backport the renaming of the FolderName parameter even to 12_5_X (see #39859 (comment), and #39897 (comment)), to avoid the need for a ConfDB parsing of a future 12_5_X release in the midst of the Hion test run (the description of this PR has been updated accordingly).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b454d/28636/summary.html
COMMIT: 3af98ee
CMSSW: CMSSW_12_5_X_2022-10-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39896/28636/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3702776
  • DQMHistoTests: Total failures: 1013
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3701740
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 221.01100000000002 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.039 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 11634.0,... ): 27.582 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #39896 was updated. @Martin-Grunewald, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

See #39859 (comment).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b454d/28648/summary.html
COMMIT: 3a1fd65
CMSSW: CMSSW_12_5_X_2022-10-30-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39896/28648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3702776
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3702742
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 55.519 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.039 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 138.5,... ): 27.582 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@emanueleusai
Copy link
Member

testing 12_4 backport at p5

@syuvivida
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 5, 2022

+1

@cmsbuild cmsbuild merged commit 817700f into cms-sw:CMSSW_12_5_X Nov 5, 2022
@missirol missirol deleted the devel_onlineMetaDataToLumiMon_125X branch March 3, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants