Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change threshold for presample mean in ECAL DQM Pedestal Quality plot [12_4_X] #39944

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Oct 31, 2022

PR description:

This PR changes the threshold for presample mean in the forward region of ECAL in the Pedestal Quality plot. This removes the many red spots which populate the forward region in the pedestal quality and consequently, the global quality plots of ECAL DQM.

PR validation:

Validated by running the standard online Ecal DQM configuration and checking the output on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of the Master PR: #39941

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2022

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Nov 1, 2022

backport of #39941

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

also testing at p5

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d9d02/28728/summary.html
COMMIT: 7a3f0b1
CMSSW: CMSSW_12_4_X_2022-11-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39944/28728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3719758
  • DQMHistoTests: Total failures: 75
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3719661
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

p5 tests completed successfully

@emanueleusai
Copy link
Member

+1

  • differences in ECAL DQM plots as per PR description

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • DQM changes, master branch is okay for this backport.

@cmsbuild cmsbuild merged commit 81c8477 into cms-sw:CMSSW_12_4_X Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants