-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change threshold for presample mean in ECAL DQM Pedestal Quality plot [12_4_X] #39944
Conversation
A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_4_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #39941 |
please test |
also testing at p5 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d9d02/28728/summary.html Comparison SummarySummary:
|
p5 tests completed successfully |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
This PR changes the threshold for presample mean in the forward region of ECAL in the Pedestal Quality plot. This removes the many red spots which populate the forward region in the pedestal quality and consequently, the global quality plots of ECAL DQM.
PR validation:
Validated by running the standard online Ecal DQM configuration and checking the output on a test DQM GUI.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a backport of the Master PR: #39941