Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log(pt) to jet DQM - backport to 12_5_X #40001

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

rseidita
Copy link
Contributor

@rseidita rseidita commented Nov 7, 2022

PR description:

Adding log(pt) plot for jets in offline DQM to spot events containing jets with anomalously high pt.

PR validation:

runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39997, to have the additional plot available in data taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2022

A new Pull Request was created by @rseidita for CMSSW_12_5_X.

It involves the following packages:

  • DQMOffline/JetMET (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@rseidita rseidita changed the title Adding log(pt) to jet DQM Adding log(pt) to jet DQM - backport to 12_5_X Nov 7, 2022
@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-580fcc/28848/summary.html
COMMIT: 6c7170c
CMSSW: CMSSW_12_5_X_2022-11-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40001/28848/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734658
  • DQMHistoTests: Total failures: 145
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3734491
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 92.67699999999998 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1.733 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10024.0,... ): 3.478 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 13234.0,... ): 1.744 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 140.53 ): 0.448 KiB JetMET/Jet
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

backport of #39997

@emanueleusai
Copy link
Member

+1

  • failures have nothing to do with this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 93b0554 into cms-sw:CMSSW_12_5_X Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants