-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Run 3 patjet process with supported b-taggers #40043
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40043/33000
|
A new Pull Request was created by @yuanchao (Yuan CHAO) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
assign alca |
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b796/28965/summary.html Comparison SummarySummary:
|
@yuanchao are those changes in the relvals expected? |
@ChrisMisan "pfCombinedInclusiveSecondaryVertexV2BJetTags" is to replaced with "pfDeepCSVJetTags:probb". Changes related with b-tagging are expected. |
please test refreshing the results |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b796/29419/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
@clacaputo are you satisfied with the refreshed test results? :) |
It is not clear why also some Phase-2 wf are affected |
hi @clacaputo they are affected as Phase-2 era inherits from the Run-3 modifier. Based on the original HN request https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4481.html these taggers are for sure not supported / used in the Phase-2, i.e. we can ignore these differences! Thanks |
+reconstruction |
hi @swertz given the decrease in size for NanoAOD in #40043 (comment) and the comment #40043 (comment) about Phase-2 would you please sign this? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Regarding the AlCa issue #58 (cms-AlCaDB/AlCaTools#58), old b-tagging GT records are request to be removed (starting) from 12_1_X (and so on). Due to the dependency on "BTauGenericMVAJetTagComputerRcd" and "JetTagComputerRecord", the corresponding b-tagging computers need to be masked in run3. Only DNN taggers will be the only supported ones in run3. To accommodate the change, this PR changes the discriminator sources with Era Modifier.
PR validation:
PR tested locally with runTheMatrix with Run3 era and 125X_mcRun3_2022_realistic_Queue condition.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport and no backport expected.