Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run 3 patjet process with supported b-taggers #40043

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

yuanchao
Copy link
Contributor

@yuanchao yuanchao commented Nov 10, 2022

PR description:

Regarding the AlCa issue #58 (cms-AlCaDB/AlCaTools#58), old b-tagging GT records are request to be removed (starting) from 12_1_X (and so on). Due to the dependency on "BTauGenericMVAJetTagComputerRcd" and "JetTagComputerRecord", the corresponding b-tagging computers need to be masked in run3. Only DNN taggers will be the only supported ones in run3. To accommodate the change, this PR changes the discriminator sources with Era Modifier.

PR validation:

PR tested locally with runTheMatrix with Run3 era and 125X_mcRun3_2022_realistic_Queue condition.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport and no backport expected.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40043/33000

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @AnnikaStein, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@ChrisMisan
Copy link
Contributor

please test

@tvami
Copy link
Contributor

tvami commented Nov 10, 2022

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b796/28959/summary.html
COMMIT: 7f7223e
CMSSW: CMSSW_12_6_X_2022-11-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40043/28959/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 788 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416447
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416380
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 10, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b796/28965/summary.html
COMMIT: 7f7223e
CMSSW: CMSSW_12_6_X_2022-11-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40043/28965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 788 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416447
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416380
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

@yuanchao are those changes in the relvals expected?

@yuanchao
Copy link
Contributor Author

@ChrisMisan "pfCombinedInclusiveSecondaryVertexV2BJetTags" is to replaced with "pfDeepCSVJetTags:probb". Changes related with b-tagging are expected.

@clacaputo
Copy link
Contributor

please test

refreshing the results

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b796/29419/summary.html
COMMIT: 7f7223e
CMSSW: CMSSW_13_0_X_2022-12-01-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40043/29419/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 906 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421101
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 14933
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 14933
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.213 2.213 0.000 ( +0.0% ) 9.26 9.27 -0.1% 1.524 1.509
2500.311 2.334 2.334 0.000 ( +0.0% ) 8.91 9.01 -1.1% 1.901 1.872
2500.312 2.288 2.288 0.000 ( +0.0% ) 8.99 9.16 -1.9% 1.886 1.864
2500.33 1.103 1.103 0.000 ( +0.0% ) 20.53 20.54 -0.0% 1.685 1.685
2500.331 1.403 1.403 0.000 ( +0.0% ) 15.10 15.56 -2.9% 1.846 1.847
2500.332 1.336 1.336 0.000 ( +0.0% ) 16.89 17.29 -2.3% 1.787 1.788
2500.4 2.109 2.109 0.000 ( +0.0% ) 9.98 10.13 -1.5% 1.426 1.409
2500.401 2.136 2.136 0.000 ( +0.0% ) 9.94 10.11 -1.7% 1.240 1.216
2500.5 0.301 0.301 0.000 ( +0.0% ) 49.73 53.49 -7.0% 1.170 1.152
2500.501 0.301 0.301 0.000 ( +0.0% ) 50.04 53.28 -6.1% 1.175 1.168
2500.51 1.075 1.075 0.000 ( +0.0% ) 26.95 28.32 -4.8% 1.422 1.400
2500.511 1.107 1.107 0.000 ( +0.0% ) 26.20 27.28 -4.0% 1.454 1.436
2500.6 1.413 1.413 0.000 ( +0.0% ) 22.53 23.71 -5.0% 1.124 1.102
2500.601 1.445 1.445 0.000 ( +0.0% ) 22.10 23.10 -4.3% 1.152 1.142

@tvami
Copy link
Contributor

tvami commented Dec 5, 2022

@clacaputo are you satisfied with the refreshed test results? :)

@clacaputo
Copy link
Contributor

It is not clear why also some Phase-2 wf are affected

@tvami
Copy link
Contributor

tvami commented Dec 7, 2022

It is not clear why also some Phase-2 wf are affected

hi @clacaputo they are affected as Phase-2 era inherits from the Run-3 modifier. Based on the original HN request https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4481.html these taggers are for sure not supported / used in the Phase-2, i.e. we can ignore these differences! Thanks

@clacaputo
Copy link
Contributor

+reconstruction

@tvami
Copy link
Contributor

tvami commented Dec 8, 2022

hi @swertz given the decrease in size for NanoAOD in #40043 (comment) and the comment #40043 (comment) about Phase-2 would you please sign this?

@swertz
Copy link
Contributor

swertz commented Dec 9, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants