HcalDQM: Add protection to collection non-exist case for GPUTask, backport of PR #40117

[lwang046]

PR description:

Backport of PR #40117 , corrects the reference&target name mixing in the hcalgpu task, adds some conditions to the collections non-exist case instead of throwing out fetal exception, and correct a minor numeric error in the DigiTask that should mod the LS by 60, instead of 50.

[cmsbuild]

A new Pull Request was created by @lwang046 for CMSSW_12_5_X.

It involves the following packages:

• DQM/HcalCommon (dqm)
• DQM/HcalTasks (dqm)
• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@DryRun, @battibass, @abdoulline, @bsunanda, @francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from HcalDQM: Add protection to collection non-exist case for GPUTask #40117

[syuvivida]

@lwang046 could you also create a backport to CMSSW_12_4_X?

[lwang046]

@lwang046 could you also create a backport to CMSSW_12_4_X?

Done

[cmsbuild]

Pull request #40118 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

type hcal,bugfix

[emanueleusai]

backport of #40117

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4b2af/29163/summary.html
COMMIT: 521e5a5
CMSSW: CMSSW_12_5_X_2022-11-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40118/29163/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3734871
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3734841
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 216 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[syuvivida]

+1
Tested at P5 with run 362217 and 362316. Both finished without crashing. Run 362316 also gave meaningful figures in DQMGUI. In the production run 362217, the previous version of hcalgpu crashed because hltHbherecoFromGPU was not found. Now with this PR, the run returns an warning and finishes without crashing.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request #40118 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[cmsbuild]

Pull request #40118 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[rvenditti]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4b2af/29266/summary.html
COMMIT: 1242f3f
CMSSW: CMSSW_12_5_X_2022-11-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40118/29266/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3722333
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3722309
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 216 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

see comment #40119 (comment)

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

For consistency, backports in older cycles should be propagated to all intermediate ones. You prepared the backports for 12_5_X and 12_4_X: please prepare also the backport for 12_6_X. We'll wait merging these ones until the 12_6_X version of this PR is submitted, at leasr

[rappoccio]

+1

All backports prepared now.