Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VertexWord.h sumPt to 12b format, 10b int. #40274

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

epalencia
Copy link
Contributor

(cherry picked from commit 449e51f)

PR description:

The Vertex Word constants are updated to increase the SumPt integer (magnitude) from 8b to 10b (total of 12b)

Local PR: cms-l1t-offline#1057

PR validation:

The outputs of this PR match corresponding changes in the firmware outputs.

The standard code-checks/formatting are performed on the updated code

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40274/33326

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

A new Pull Request was created by @epalencia (Enrique Palencia Cortezon) for master.

It involves the following packages:

  • DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @eyigitba, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45217d/29544/summary.html
COMMIT: e86b4a5
CMSSW: CMSSW_13_0_X_2022-12-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40274/29544/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421510
  • DQMHistoTests: Total failures: 155
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421333
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 547b357 into cms-sw:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants