Avoid short-circuiting ESWatchers in ElectronSeedGenerator

[Dr15Jones]

PR description:

Be sure to call check for all ESWatchers for each event.

PR validation:

Code compiles.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40303/33372

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• RecoEgamma/EgammaElectronAlgos (reconstruction)

@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @sameasy, @valsdav, @lgray, @missirol, @sobhatta, @afiqaize, @wrtabb, @a-kapoor, @Prasant1993, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6513c2/29588/summary.html
COMMIT: 2b62829
CMSSW: CMSSW_13_0_X_2022-12-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40303/29588/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 29 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421510
• DQMHistoTests: Total failures: 1192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3420296
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• The fix is technically rather trivial. I take the liberty to merge it in time for the 1100 IB, but please @cms-sw/reconstruction-l2 complain if you don't agree with it, and we can always revert it if so.

[perrotta]

merge

[mandrenguyen]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.