Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackingMonitor: extend lumi monitoring for Run-3 to 2.5E34 and remove SCAL in labels #40344

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 16, 2022

PR description:

Title says it all, current limits are exceeded by Run-3 inst lumi projections.

PR validation:

None (but changes are trivial)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40344/33433

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/TrackingMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @VourMa, @hdelanno, @sroychow, @JanFSchulte, @VinInn, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 16, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de00bf/29655/summary.html
COMMIT: 768e0cd
CMSSW: CMSSW_13_0_X_2022-12-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40344/29655/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557521
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 4418
  • DQMHistoTests: Total successes: 3553081
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 280.957 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 7.617 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): 7.617 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 11634.0,... ): 3.809 KiB HLT/EGM
  • DQMHistoSizes: changed ( 138.4,... ): 4.395 KiB AlCaReco/SiStripCalMinBias
  • DQMHistoSizes: changed ( 138.4,... ): 4.395 KiB AlCaReco/TkAlMinBias
  • DQMHistoSizes: changed ( 138.5,... ): 67.969 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 138.5 ): 4.395 KiB AlCaReco/SiStripCalMinBiasAAG
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40344/33490

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40344 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 20, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de00bf/29720/summary.html
COMMIT: da99704
CMSSW: CMSSW_13_0_X_2022-12-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40344/29720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 157
  • DQMHistoTests: Total nulls: 4288
  • DQMHistoTests: Total successes: 3551071
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -307.769 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -31.849 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -31.493 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 11634.0,... ): -15.736 KiB HLT/EGM
  • DQMHistoSizes: changed ( 138.4,... ): 4.395 KiB AlCaReco/SiStripCalMinBias
  • DQMHistoSizes: changed ( 138.4,... ): 4.395 KiB AlCaReco/TkAlMinBias
  • DQMHistoSizes: changed ( 138.5,... ): 67.969 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 138.5 ): 4.395 KiB AlCaReco/SiStripCalMinBiasAAG
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

Looking at the DQM bin-by-bin comparisons, I understand the differences in plots vs Lumi, but I don;t get the differences in other plots such as: residual_x_per_SignedModule_per_SignedLadder, see e.g.:
https://tinyurl.com/2l6kby2p

@mmusich
Copy link
Contributor Author

mmusich commented Jan 7, 2023

@emanueleusai

Looking at the DQM bin-by-bin comparisons, I understand the differences in plots vs Lumi, but I don;t get the differences in other plots such as: residual_x_per_SignedModule_per_SignedLadder, see e.g.:
https://tinyurl.com/2l6kby2p

the difference you are pointing to refers to wf. 11634.7 that is known to generate spurious differences see #39803

@emanueleusai
Copy link
Member

good point, thank you

@emanueleusai
Copy link
Member

+1

  • DQM plot differences expected in vs_lumi plots
  • other differences spurious

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jan 8, 2023

+1

@cmsbuild cmsbuild merged commit a0a9386 into cms-sw:master Jan 8, 2023
@mmusich mmusich deleted the extendLumiMonitoringRun3 branch January 8, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants