Phase2-hgx333C Take care of invalid SiHits for V16 geometry of HGCal

[bsunanda]

PR description:

Take care of invalid SiHits for V16 geometry of HGCal

PR validation:

Use the test codes in Validation/HGCalValidation/scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40381/33499

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• Validation/HGCalValidation (dqm)

@civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @fabiocos, @sethzenz, @missirol, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @trtomei, @ebrondol, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40381/33502

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #40381 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51ec36/29730/summary.html
COMMIT: 520f513
CMSSW: CMSSW_13_0_X_2022-12-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40381/29730/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12340 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555748
• DQMHistoTests: Total failures: 7198
• DQMHistoTests: Total nulls: 28
• DQMHistoTests: Total successes: 3548500
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: found differences in 2 / 47 workflows

[bsunanda]

+geometry

[bsunanda]

@srimanob Please sign this PR

[srimanob]

+Upgrade

Differences are seen in V16 HGCAL geometry.

[bsunanda]

@emanueleusai, @ahmad3213 Please approve this PR. It is needed to have the right functionality of V16 geometry of HGCal which is now used in the default Phase2 scenario

[emanueleusai]

+1

• differences in upgrade WFs as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1