[12.5.X] Adjust collections of Tracker clusters to be saved for Phase-2 ALCARECO

[mmusich]

PR description:

This is a follow-up of PR #39858.
After the backport of that PR (#39898) was integrated, it was possible to test the production of RelVal samples (see e.g. on DAS: /RelValMinBias_14TeV/CMSSW_12_5_2-TkAlMinBias-125X_mcRun4_realistic_v3_2026D88PU-v1/ALCARECO).
When trying to run over it, it became clear that is not possible to refit tracks, due to the missing event products (the Phase-2 Outer Tracker clusters) that are necessary for CPE re-computation, leading to this error:

Begin processing the 1st record. Run 1, Event 301, LumiSection 4 on stream 6 at 13-Dec-2022 12:50:01.219 CET
----- Begin Fatal Exception 13-Dec-2022 12:50:57 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 4 event: 306 stream: 2
   [1] Running path 'p2'
   [2] Calling method for module TrackRefitter/'FinalTrackRefitter'
Exception Message:
RefCore: A request to resolve a reference to a product of type 'edmNew::DetSetVector<Phase2TrackerCluster1D>' with ProductID '4:449'
can not be satisfied because the product cannot be found.
Probably the branch containing the product is not stored in the input file.
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

This PR adds the minimal amount of changes in the CommonTools/RecoAlgos package in order to be able to retain the Phase-2 OT clusters after running the AlignmentTrackSelector module that relies on it:

cmssw/Alignment/CommonAlignmentProducer/plugins/AlignmentTrackSelectorModule.cc

Lines 13 to 17 in 52c0dac

	// the following include is necessary to clone all track branches
	// including recoTrackExtras and TrackingRecHitsOwned (in future also "owned clusters"?).
	// if you remove it the code will compile, but the cloned
	// tracks have only the recoTracks branch!
	#include "CommonTools/RecoAlgos/interface/TrackSelector.h"

This is done in commit 3c18fe0.
Secondly the outputCommands of all the Tracker Alignment ALCARECO producers is modified in order to retain Phase2TrackerCluster1DedmNewDetSetVector in the output - in case the production is run for Phase-2 - while removing SiStripClusteredmNewDetSetVector (since there is no SiStrip detector in phase-2). I profit of that to re-adjust the commands for event contents to cope with no SCAL in Run3 that were leftover from #38415 and #38590.
This is done in commit 19e04f4.
Additionally this contains commit 06b919b which fixes a problem with the vector hits workflow spotted in master and commit 651c25a which makes the ClusterStorer::rekey methods non-const as per recommendations in #40363.

PR validation:

Run two typical workflows for Run-3 and Phase-2 with

runTheMatrix.py -l 11634.0,20834.0 -t 4 -j 8 --ibeos

And tested the event content of TkAlMinBias indeed changes as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a combined backport of #40323 and #40363 (partially backported). It is backported in this cycle in order to use it for the production of ALCARECOs within the context of the L1T production happening in that cycle, see https://its.cern.ch/jira/browse/PDMVRELVALS-178 and McM

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)
• CommonTools/RecoAlgos (reconstruction)
• DataFormats/TrackerRecHit2D (reconstruction)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @rappoccio, @jdolen, @tlampen, @VourMa, @adewit, @ahinzmann, @abbiendi, @JanFSchulte, @rovere, @VinInn, @missirol, @gkasieczka, @tocheng, @hatakeyamak, @gpetruc, @mmusich, @mtosi, @jhgoh this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Adjust collections of Tracker clusters to be saved for Phase-2 ALCARECO #40323

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5c197/29753/summary.html
COMMIT: 651c25a
CMSSW: CMSSW_12_5_X_2022-12-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40395/29753/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testEoP had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3724047
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3724023
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 216 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mmusich]

I found errors in the following unit tests:
---> test testEoP had ERRORS

unit tests failures are unrelated and already happening in the IBs.
It's being take care of at #40401

[mmusich]

backport of #40323

[mmusich]

backport of #40363 (partial)

[tvami]

+alca

[mandrenguyen]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge