-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PSet-based ctor of EventSelector
#40432
remove PSet-based ctor of EventSelector
#40432
Conversation
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40432/33573
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Looks good, thanks for the cleanup! |
test parameters: |
please test The latest IB includes #40420, and this PR can now be tested without extra dependencies. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51cc83/30025/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
After the cleanup being done in #40420, the PSet-based constructor of
EventSelector
would only be used in 3 unit tests ofFWCore/Framework
.This PR removes said ctor (and updates the unit tests accordingly), following the discussion in #40420 (comment).
Merely technical. No changes expected.
Requires #40420.
PR validation:
The unit tests of
FWCore/Framework
passed.If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A