Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GEM inputs for L1REPACK:FullMC [12_4_X] #40470

Merged

Conversation

missirol
Copy link
Contributor

backport of #40461
(verbatim backport)

PR description:

This PR fixes the L1REPACK:FullMC step (full simulation of trigger primitives + emulation of L1T from RAW in MC events [ref]), where GEM inputs are currently misconfigured. This type of configuration is used in offline trigger studies, even though it is untested in CMSSW.

For further details, please the description of the original PR, i.e. #40461.

Small edits are applied to other L1REPACK cffs, to fix a few print-outs (see #40461 (comment) for details).

PR validation:

None beyond the checks done for #40461.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40461

Trigger studies in 12_4_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

type bugfix

This fix alone does not warrant a new release (users can locally merge this PR, if needed).

At the same time, I think it would be good to merge it to ease trigger studies.

@missirol
Copy link
Contributor Author

FYI: @cms-sw/l1-l2

(Feel free to "assign l1", but I don't think it's necessary given that the equivalent #40461 was signed by L1T.)

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c7b20/29898/summary.html
COMMIT: fd4663d
CMSSW: CMSSW_12_4_X_2023-01-08-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40470/29898/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3709270
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 0a38161 into cms-sw:CMSSW_12_4_X Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants