Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/RPCMonitorClient fixes. #4051

Merged
merged 2 commits into from Jun 4, 2014
Merged

Conversation

acimmino
Copy link
Contributor

Bug fixes.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acimmino (Anna Cimmino) for CMSSW_7_1_X.

29 05 2014

It involves the following packages:

DQM/RPCMonitorClient
DQM/RPCMonitorDigi

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented May 30, 2014

Please use a sensible title for the PR. It goes into the release notes.

@acimmino
Copy link
Contributor Author

Dear Giulio,

Should I "redo" the PR and change the title or was this just a suggestion for next time?

Anna


From: Giulio Eulisse [notifications@github.com]
Sent: 30 May 2014 11:47
To: cms-sw/cmssw
Cc: Anna Cimmino
Subject: Re: [cmssw] 29 05 2014 (#4051)

Please use a sensible title for the PR. It goes into the release notes.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4051#issuecomment-44633859.

@ktf
Copy link
Contributor

ktf commented May 30, 2014

Just edit the title (there should be an "edit" link at the top).

@cmsbuild
Copy link
Contributor

@acimmino acimmino changed the title 29 05 2014 BugFixes_RE4_7_1_X May 30, 2014
@acimmino
Copy link
Contributor Author

PR title changes, as requested.

@ktf ktf changed the title BugFixes_RE4_7_1_X DQM/RPCMonitorClient fixes. May 30, 2014
@ktf
Copy link
Contributor

ktf commented May 30, 2014

I've changed the title to "DQM/RPCMonitorClient fixes." which is a bit more clean. Keep in mind that this is something people read when reading the release notes.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jun 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 4, 2014
@davidlange6 davidlange6 merged commit 596f6c5 into cms-sw:CMSSW_7_1_X Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants