53x improve lumilist #4061
53x improve lumilist #4061
Conversation
|
A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_5_3_X. 53x improve lumilist It involves the following packages: FWCore/PythonUtilities @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
| @@ -42,7 +43,7 @@ class LumiList(object): | |||
| """ | |||
|
|
|||
|
|
|||
| def __init__(self, filename = None, lumis = None, runsAndLumis = None, runs = None, compactList = None): | |||
| def __init__(self, filename = None, url = None, lumis = None, runsAndLumis = None, runs = None, compactList = None): | |||
There was a problem hiding this comment.
Why not add this at the end to avoid breaking any calls which pass arguments without names?
There was a problem hiding this comment.
Nice idea, but it shouldn't ever happen. Only one of those arguments can be used at a time to construct the list
|
+1 |
|
-1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
|
+tested |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). @smuzaffar can you please take care of it? |
|
@davidlange6 Can you +orp this? |
No description provided.