Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (2/N) #40791

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

missirol
Copy link
Contributor

backport of #40790

PR description:

Development of HLT menus for CMSSW_13_0_X.

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2592: [TSG] removal of deprecated GRun Paths post Run2022 (combined table unchanged)
  • CMSHLT-2593: [TSG] remove unused Paths from HLT combined menu (post Run2022)
  • CMSHLT-2596: [TSG] split EGamma,JetMET,Muon datasets and streams by 2
  • CMSHLT-2605: [GEM] extend RPCMON stream to GEM
  • CMSHLT-2607: [PPS] extend list of CT-PPS FEDs
  • CMSHLT-2613: [EGM] added two MC_Egamma_Open Paths (only to combined table)
  • CMSHLT-2633: [EXO] update of displaced Photon+PFHT trigger and addition of backups

It also includes the migration of the HLT menus ("Fake*", frozen, and development ones) to the ConfDB template for CMSSW_13_0_0_pre4.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40790

Development of HLT menus for 2023 data-taking and Run-3 MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e53a/30670/summary.html
COMMIT: 1426e4d
CMSSW: CMSSW_13_0_X_2023-02-16-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40791/30670/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.878136.878_RunMuonEG2018C/step2_RunMuonEG2018C.log
  • 136.877136.877_RunMET2018C/step2_RunMET2018C.log
  • 136.879DAS Error

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 52 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3523922
  • DQMHistoTests: Total failures: 1183
  • DQMHistoTests: Total nulls: 84
  • DQMHistoTests: Total successes: 3522633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -93310.84 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -9818.210 KiB HLT/BTV
  • DQMHistoSizes: changed ( 11634.0,... ): -1531.818 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -1187.008 KiB HLT/TOP
  • DQMHistoSizes: changed ( 11634.0,... ): -1130.035 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): -474.491 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -274.408 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -152.027 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -117.172 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -55.156 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 37.609 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

GPU Comparison Summary

Summary:

  • You potentially removed 134 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 238
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19624
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@missirol
Copy link
Contributor Author

please test

The RelVals-INPUT error is not a time-out. It's probably transient and unrelated to these HLT changes, but to be extra-safe the tests are restarted.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e53a/30686/summary.html
COMMIT: 1426e4d
CMSSW: CMSSW_13_0_X_2023-02-16-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40791/30686/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 21 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3523922
  • DQMHistoTests: Total failures: 1186
  • DQMHistoTests: Total nulls: 84
  • DQMHistoTests: Total successes: 3522630
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -93310.84 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -9818.210 KiB HLT/BTV
  • DQMHistoSizes: changed ( 11634.0,... ): -1531.818 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -1187.008 KiB HLT/TOP
  • DQMHistoSizes: changed ( 11634.0,... ): -1130.035 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): -474.491 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -274.408 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -152.027 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -117.172 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -55.156 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 37.609 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 264
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19598
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@missirol
Copy link
Contributor Author

+hlt

  • changes in the outputs of PR tests are in line with updates to the HLT GRun menu, and the change in name of the frozen/fake HLT menus

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 28633a5 into cms-sw:CMSSW_13_0_X Feb 17, 2023
@missirol missirol deleted the HLTdevelopment130X branch February 17, 2023 13:09
@missirol
Copy link
Contributor Author

@rappoccio , maybe this merge was a bit quick, but I don't expect any issues (so no further action needed, imho).

This kind of HLT backport is usually merged after we see no problems in the master IB (in this case, CMSSW_13_1_X_2023-02-17-1100 which includes #40790 and is still running).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants