Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex153X Backport #40783 to CMSSW version 13_0_X the 2023 Geometry modified because of shifted positions of GE21 Chambers #40816

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport #40783 to CMSSW version 13_0_X the 2023 Geometry modified because of shifted positions of GE21 Chambers

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport #40783 to CMSSW_13_0_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/MuonCommonData (geometry)

@perrotta, @rappoccio, @Dr15Jones, @bsunanda, @makortel, @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @ptcox, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41cef5/30732/summary.html
COMMIT: ef12b47
CMSSW: CMSSW_13_0_X_2023-02-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40816/30732/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529001
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Feb 19, 2023

+1

@civanch
Copy link
Contributor

civanch commented Feb 22, 2023

Let us sign this PR and merge. The master one #40783 is already merged. This one does not affect any WF, because by default geometry is taken from DB.

This PR is needed, because 13_0 is the baseline for 2023 production, so XML version of the geometry should correspond to the DB one.

@bsunanda
Copy link
Contributor Author

@srimanob Please sign this PR so that it can get into 13_0 release

@srimanob
Copy link
Contributor

+Upgrade

@perrotta
Copy link
Contributor

+1

  • As stated when merging the corresponding PR in the master, we currently rely on some private validation made by @bsunanda, but before using for 2023 (i.e. enabling the modified geometry via db) a complete validation by the GEM group is mandatory

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 6cd9086 into cms-sw:CMSSW_13_0_X Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants