Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Move dictionary declarations of Alpaka serial backend data products to the host classes_def.xml #40826

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

makortel
Copy link
Contributor

PR description:

This PR backports #40792. Original PR description

This PR moves the dictionary declarations of Alpaka serial backend data products to the host classes_def.xml. The "serial" data products are intended to be consumable by non-Alpaka EDModules as well, so having all of their definitions in the main library is more consistent. See more discussion in #40690 (comment) .

PR validation:

None beyond #40792.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40792 (with the same commit)

…def.xml

The 'serial' data products are intended to be consumable by non-Alpaka
EDModules as well, so all their definitions should be in the main,
non-Alpaka-backend library.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2023

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_0_X.

It involves the following packages:

  • DataFormats/PortableTestObjects (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

enable gpu

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9be8f3/30758/summary.html
COMMIT: a71fc2e
CMSSW: CMSSW_13_0_X_2023-02-20-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40826/30758/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1197 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528994
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • You potentially removed 62 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 235
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19627
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@makortel
Copy link
Contributor Author

backport of #40792

@makortel
Copy link
Contributor Author

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@fwyzard
Copy link
Contributor

fwyzard commented Feb 22, 2023

@perrotta the latest 13.1.x IBs is still a patch :-(
Is there a way to force building a full release ?
Or, do you consider CMSSW_13_1_ROOT626_X_2023-02-21-2300 a valid test (see #40844 (comment)) ?

@perrotta
Copy link
Contributor

unhold

  • CMSSW_13_1_ROOT626_X_2023-02-21-2300 is a full build, and in fact the unit test errors do not show up there any more, as anticipated by @makortel

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1c89fbe into cms-sw:CMSSW_13_0_X Feb 22, 2023
@makortel makortel deleted the serialDictionary branch February 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants