Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex154A Fix the issue of 2026D94 which can now work in the dd4hep version #40837

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Feb 21, 2023

PR description:

Fix the issue of 2026D94 which can now work in the dd4hep version. In the earlier version, any cmdim job with this scenario and dd4hep used to crash in the very first event with
in HGCalNumberingInitialization::produce for HGCalHEScintillatorSensitive
----- Begin Fatal Exception 20-Feb-2023 11:02:17 CET-----------------------
An exception of category 'NoProxyException' occurred while
[0] Processing global begin Run run: 1
[1] Prefetching for module OscarMTProducer/'g4SimHits'
[2] Prefetching for EventSetup module HGCalNumberingInitialization/'hgcalEENu
mberingInitialize'
[3] Calling method for EventSetup module HGCalParametersESModule/'hgcalEEParametersInitialize'
Exception Message:
No data of type "DDCompactView" with label "" in record "IdealGeometryRecord"

Now this step goes through successfully

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It is a bug fix and need to be back ported to 13_0_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40837/34291

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/ForwardCommonData (geometry)
  • Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@srimanob
Copy link
Contributor

Please abort

@srimanob
Copy link
Contributor

test parameters:

  • workflow = 23234.911

@srimanob
Copy link
Contributor

@cmsbuild please test

@srimanob
Copy link
Contributor

test parameters:

@srimanob
Copy link
Contributor

test parameters:

  • workflow = 23234.911
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3368/30787/summary.html
COMMIT: d3c7d21
CMSSW: CMSSW_13_1_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40837/30787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528684
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Feb 22, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants