SiPixelDynamicInefficiency_PayloadInspector: add polynomial representation plot of inefficiency vs inst lumi

[mmusich]

PR description:

The goal of this PR is to introduce a new plotting class for the SiPixelDynamicInefficiency_PayloadInspector in order to validate the polynomial expansion of the PU-dependent double column inefficiency factors in the SiPixelDynamicInefficiency payloads, since there were some hiccups during the production of the payloads needed for the 2023 MC production (see thread at https://its.cern.ch/jira/browse/PDMVRELVALS-188).
The class is not yet refined and there are certainly possible improvements. These can be followed up in a subsequent PR.
This PR is meant to allow the SiPixel DB contact to have access to this type of validation early on in the submission process, as soon as possible.

PR validation:

Relies on private tests.
This is an example of plot that can be obtained with the following command:

getPayloadData.py --plugin pluginSiPixelDynamicInefficiency_PayloadInspector --plot plot_SiPixelDynamicInefficiencyPUParametrization --tag SiPixelDynamicInefficiency_phase1_2023_v2 --time_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --db Prod --test ;

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40856/34314

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/SiPixelPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@VinInn, @mroguljic, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b3ffe/30825/summary.html
COMMIT: 85a97bd
CMSSW: CMSSW_13_1_X_2023-02-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40856/30825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.596 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3528709
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528681
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request #40856 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[perrotta]

please let's get all comments before wasting another test round.

I have no additional comments from myself: feel free to launch the tests as soon as you believe that you collected and implemented all other comments

[mmusich]

@cms-sw/alca-l2 please trigger tests if you are happy.

[tvami]

@cmsbuild , please test

• and I actually propose to merge this after the unit test passed (nothing else is affected anyway)

[mmusich]

unit tests have already passed.

[tvami]

+db

• really no point in waiting longer, all relvals passed in the earlier round, since then minor changes in the code, and the real test happens in the unit test that is passed. @perrotta can we merge asap?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Guys, you tend to forget that IBs are quantized. Next IB will be built at 23:00, and if we either merge this PR now or at 22:59 nothing changes.
Since this PR looks so urgent, I commit to merge it by 22:59 in the (quite unlikely) case that the tests are not completed by then

[tvami]

I commit to merge

was that a pun? :D

Anyway, thanks Andrea! Sounds good!

[perrotta]

was that a pun? :D

Unwanted, indeed :D

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b3ffe/30832/summary.html
COMMIT: 8dc8461
CMSSW: CMSSW_13_1_X_2023-02-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40856/30832/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

There are some workflows for which there are errors in the baseline:
22034.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3528709
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528684
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[rappoccio]

+1

relval input errors look unrelated.

[rappoccio]

please merge