-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixelDynamicInefficiency_PayloadInspector
: add polynomial representation plot of inefficiency vs inst lumi
#40856
Conversation
…ation plot of dcol inefficiency vs inst lumi
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40856/34314
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b3ffe/30825/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
CondCore/SiPixelPlugins/plugins/SiPixelDynamicInefficiency_PayloadInspector.cc
Outdated
Show resolved
Hide resolved
CondCore/SiPixelPlugins/plugins/SiPixelDynamicInefficiency_PayloadInspector.cc
Outdated
Show resolved
Hide resolved
…iencyPUParametrization
Pull request #40856 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again. |
I have no additional comments from myself: feel free to launch the tests as soon as you believe that you collected and implemented all other comments |
@cms-sw/alca-l2 please trigger tests if you are happy. |
@cmsbuild , please test
|
unit tests have already passed. |
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Guys, you tend to forget that IBs are quantized. Next IB will be built at 23:00, and if we either merge this PR now or at 22:59 nothing changes. |
was that a pun? :D Anyway, thanks Andrea! Sounds good! |
Unwanted, indeed :D |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 relval input errors look unrelated. |
please merge |
PR description:
The goal of this PR is to introduce a new plotting class for the
SiPixelDynamicInefficiency_PayloadInspector
in order to validate the polynomial expansion of the PU-dependent double column inefficiency factors in theSiPixelDynamicInefficiency
payloads, since there were some hiccups during the production of the payloads needed for the 2023 MC production (see thread at https://its.cern.ch/jira/browse/PDMVRELVALS-188).The class is not yet refined and there are certainly possible improvements. These can be followed up in a subsequent PR.
This PR is meant to allow the SiPixel DB contact to have access to this type of validation early on in the submission process, as soon as possible.
PR validation:
Relies on private tests.
This is an example of plot that can be obtained with the following command:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A